Models: Fix typing issue for optional fields. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenhamou
force-pushed
the
fix-typing-issue
branch
from
e656c7f
to
10ea038
Compare
|
@tbenhamou Thank you for opening this pull request. Could you please confirm this PR follows our licensing guidelines as in https://github.com/apple/app-store-server-library-python/blob/main/CONTRIBUTING.md#project-licensing |
It does :) |
alexanderjordanbaker
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an attribute has a default value of None, the typing hint should specify it's optional.
BTW, why to use
attrsand not the nativedataclassesmodule of Python? It's a way more simple...