Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed test suite exits with 0 #2758

Closed
michaelrsweet opened this issue Mar 16, 2008 · 2 comments
Closed

failed test suite exits with 0 #2758

michaelrsweet opened this issue Mar 16, 2008 · 2 comments
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.3.6
CUPS.org User: martin.pitt.canonical

Unlike most other test suites, a failed 'make check' exits with 0. For integration into package build scripts it would be much easier, as well as more conventional to exit with zero only if all tests succeed.

(Background: when building on 11 architectures, failing the build when the test suite suddenly starts failing is a great way to automatically detect problems on particular architectures, as well as forcing maintainers to keep the test suite working, and thus useful.)

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

Simpler patch attached...

@michaelrsweet
Copy link
Collaborator Author

"str2758.patch":

Index: test/run-stp-tests.sh

--- test/run-stp-tests.sh (revision 7376)
+++ test/run-stp-tests.sh (working copy)
@@ -598,6 +598,10 @@
echo "A HTML report was created in test/$strfile."
echo ""

+if test $fail != 0; then

  • exit 1
    +fi

End of "$Id$"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant