Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Jobs moves processing jobs as stopped to destination #3222

Closed
michaelrsweet opened this issue Jun 11, 2009 · 2 comments
Closed

Move Jobs moves processing jobs as stopped to destination #3222

michaelrsweet opened this issue Jun 11, 2009 · 2 comments
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.3.10
CUPS.org User: rojon

When using jobs to another destination, the currently processed job will show up at the destination, but will not printed, due to it's state.
The state of these jobs is in this case IPP_JOB_STOPPED; due to a missing restart-job the job is not easily printable after moving.
Suggest the following patch for this:
--- scheduler/job.c@8704 Thu Apr 16 21:32:04 2009
+++ scheduler/job.c Fri Apr 17 13:16:14 2009
@@ -1351,6 +1351,9 @@
"Job #%d moved from %s to %s.", job->id, olddest,
p->name);

  • if (job->state_value == IPP_JOB_STOPPED)
  • cupsdRestartJob(job);

cupsdSaveJob(job);
}

which will restart the job after moving to the new destination.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

(already fixed in trunk for 1.4...)

@michaelrsweet
Copy link
Collaborator Author

"str3222.patch":

Index: scheduler/job.c

--- scheduler/job.c (revision 8718)
+++ scheduler/job.c (working copy)
@@ -1331,7 +1331,12 @@
*/

if (job->state_value == IPP_JOB_PROCESSING)

  • {
    cupsdStopJob(job, 0);
  • job->state_value = IPP_JOB_PENDING;
  • job->state->values[0].integer = IPP_JOB_PENDING;
  • }
    else
    cupsdLoadJob(job);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant