Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default policy in get_job_attrs() function (ipp.c) #3431

Closed
michaelrsweet opened this issue Nov 28, 2009 · 2 comments
Closed

Default policy in get_job_attrs() function (ipp.c) #3431

michaelrsweet opened this issue Nov 28, 2009 · 2 comments
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.4-current
CUPS.org User: pkun

Hello.

Function get_job_attrs() check policy against DefaultPolicyPtr but not
against policy of job's printer.

if ((status =3D cupsdCheckPolicy(DefaultPolicyPtr, con, NULL)) !=3D =
HTTP_OK)

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet
Copy link
Collaborator Author

"str3431.patch":

Index: scheduler/ipp.c

--- scheduler/ipp.c (revision 8906)
+++ scheduler/ipp.c (working copy)
@@ -6744,6 +6744,7 @@
ipp_attribute_t attr; / Current attribute /
int jobid; /
Job ID /
cupsd_job_t *job; /
Current job */

  • cupsd_printer_t printer; / Current printer /
    char scheme[HTTP_MAX_URI], /
    Method portion of URI /
    username[HTTP_MAX_URI], /
    Username portion of URI /
    host[HTTP_MAX_URI], /
    Host portion of URI */
    @@ -6818,8 +6819,20 @@
  • Check policy...
    */
  • if ((status = cupsdCheckPolicy(DefaultPolicyPtr, con, NULL)) != HTTP_OK)
  • if ((printer = job->printer) == NULL)
  • printer = cupsdFindDest(job->dest);
  • if (printer)
    {
  • if ((status = cupsdCheckPolicy(printer->op_policy_ptr, con,
  •                               NULL)) != HTTP_OK)
    
  • {
  •  send_http_error(con, status, printer);
    
  •  return;
    
  • }
  • }
  • else if ((status = cupsdCheckPolicy(DefaultPolicyPtr, con, NULL)) != HTTP_OK)
  • {
    send_http_error(con, status, NULL);
    return;
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant