Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB VID 0x0F25 should be "Primera" and not "Fargo" #4708

Closed
michaelrsweet opened this issue Sep 1, 2015 · 4 comments
Closed

USB VID 0x0F25 should be "Primera" and not "Fargo" #4708

michaelrsweet opened this issue Sep 1, 2015 · 4 comments
Milestone

Comments

@michaelrsweet
Copy link
Collaborator

Version: 2.0-current
CUPS.org User: klilland

Back in 1998 my company (Primera Technology, Inc.) registered and received from USB.org our Vendor ID for Primera Technology, Inc. (Primera).
VID = 0x0F25
However, I�ve seen the VID showing up for years in CUPS as �Fargo� instead of �Primera�. I thought I would finally try to get to the bottom of this.
I see it in both CUPS 2.0 and CUPS 1.5.3 (Mac OSX 10.10.10 and Linux Raspian). See files attached - the "Fargo" text seen is NOT being reported by our printer - CUPS must be inserting it.

Regards,
-Kevin.
Kevin Lilland
Primera Technology, Inc.
klilland@primera.com
763-475-6890 (direct)

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

This is a side-effect of the make/model normalization code. I will investigate, but this code originated to consistently report the Fargo Primera and Fargo Primera Pro printer make and model.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: klilland

Some history--
The original company was Fargo Electronics. This company sold two printers called the Primera and PrimeraPro (among others).
In 1998, Fargo Electonics was sold to some investors and a new company was formed called Primera Technology, Inc.
Primera is the owner of PID 0x0F25
Fargo Electronics (now called HID Global) owns another PID (not sure what is) and the two printers you referenced are long gone.

So, I'm hoping you can change 0x0F25 to reference "Primera" instead of "Fargo"
Thanks.

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet
Copy link
Collaborator Author

"str4708.patch":

Index: cups/attr.c

--- cups/attr.c (revision 12866)
+++ cups/attr.c (working copy)
@@ -1,22 +1,16 @@
/*

  • "$Id$"
    *

    • * PPD model-specific attribute routines for CUPS.
    • * PPD model-specific attribute routines for CUPS.
      *
    • * Copyright 2007-2012 by Apple Inc.
    • * Copyright 1997-2006 by Easy Software Products.
    • * Copyright 2007-2015 by Apple Inc.
    • * Copyright 1997-2006 by Easy Software Products.
      *
    • * These coded instructions, statements, and computer programs are the
    • * property of Apple Inc. and are protected by Federal copyright
    • * law. Distribution and use rights are outlined in the file "LICENSE.txt"
    • * which should have been included with this file. If this file is
    • * file is missing or damaged, see the license at "http://www.cups.org/".
    • * Contents:
    • * ppdFindAttr() - Find the first matching attribute.
    • * ppdFindNextAttr() - Find the next matching attribute.
    • * _ppdNormalizeMakeAndModel() - Normalize a product/make-and-model string.
    • * These coded instructions, statements, and computer programs are the
    • * property of Apple Inc. and are protected by Federal copyright
    • * law. Distribution and use rights are outlined in the file "LICENSE.txt"
    • * which should have been included with this file. If this file is
    • * file is missing or damaged, see the license at "http://www.cups.org/".
      */

    /*
    @@ -229,14 +223,6 @@

    snprintf(buffer, bufsize, "Canon %s", make_and_model);
    }

    • else if (!_cups_strncasecmp(make_and_model, "primera", 7))
    • {
    • /*
    • * Fargo...

    - */

    • snprintf(buffer, bufsize, "Fargo %s", make_and_model);
    • }
      else if (!_cups_strncasecmp(make_and_model, "designjet", 9) ||
      !_cups_strncasecmp(make_and_model, "deskjet", 7))
      {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant