Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct typos in rastertolabel #5350

Merged
merged 5 commits into from Jul 18, 2018
Merged

Correct typos in rastertolabel #5350

merged 5 commits into from Jul 18, 2018

Conversation

benlees
Copy link
Contributor

@benlees benlees commented Jul 8, 2018 •
edited

Whilst testing changes for #5092 (see rastertolabel-mods branch), I noticed a few typos in rastertolabel.

  • Zebra CPCL output appears to specify the PAGE-HEIGHT as header->cupsWidth.
  • Intellitech print density outputs an unsigned integer, where a signed integer is required
  • Related to the Intellitech print density, the values for cupsCompression in sample.drv produce the wrong output.

@benlees
Correct page height for Zebra CPCL output
eadeefa 
PAGE-HEIGHT is being set to cupsWidth rather than cupsHeight.
@benlees
Merge pull request #1 from benlees/patch-1
04e7ecd 
Correct page height for Zebra CPCL output
@benlees
Intellitech print density should be signed
e8fb750 
The print density ranges from -15 to +15.  The output should be a signed integer.
@benlees
Correct print density for Intellitech
c44a2ab 
Due to an incorrect rounding assumptions in sample.drv, selecting print density choice 14 produces an output of 13 in the driver and so on.
@benlees
Additions to print density corrections
2ea1bc0 
Missed correcting values below 50 (-14 would produce -15 in the output etc).
@michaelrsweet michaelrsweet self-assigned this Jul 9, 2018
@michaelrsweet michaelrsweet merged commit 4848b9c into apple:master Jul 18, 2018
michaelrsweet added a commit that referenced this pull request Jul 18, 2018
@michaelrsweet
Merge label driver changes (Issue #5350)
436a2c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelrsweet michaelrsweet

Labels
priority-low
Projects
None yet
Milestone
CUPS 2.2.x Updates
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benlees @michaelrsweet