Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the trace clock source doesn't work #2373

Closed
ajbeamon opened this issue Nov 20, 2019 · 1 comment
Closed

Setting the trace clock source doesn't work #2373

ajbeamon opened this issue Nov 20, 2019 · 1 comment
Assignees

Comments

@ajbeamon
Copy link
Contributor

fdbserver has an option to set the clock used for trace events to either use now() or a call to timer(). By default, it had been using the now clock.

A recent change of mine (#1875) made it so that the now clock was only used on the network thread to avoid unsafe accesses of global data from different threads. This change also had the unintended side effect of causing the clock source on the network thread to always revert to now, even if it had changed to realtime.

There was uncovered by a recent PR (#2329) to add the ability to change the clock source in clients. Changes here should consider the implications for that PR as well.

@ajbeamon
Copy link
Contributor Author

Resolved by #2420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant