New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the way how the backup agent makes use of the proxy and add proxy to trace events #10903
Merged
jzhou77
merged 2 commits into
apple:release-7.1
from
johscheuer:correct-proxy-handling-backup-agent
Sep 18, 2023
Merged
Correct the way how the backup agent makes use of the proxy and add proxy to trace events #10903
jzhou77
merged 2 commits into
apple:release-7.1
from
johscheuer:correct-proxy-handling-backup-agent
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roxy to trace events
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
hfu94
previously approved these changes
Sep 14, 2023
jzhou77
previously approved these changes
Sep 14, 2023
LGTM. The code is not format-clean. |
Yeah please run clang-format |
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
That one looks new 🤔 |
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
I ran the tests manually and all of them succeeded 🤔 |
jzhou77
approved these changes
Sep 15, 2023
hfu94
approved these changes
Sep 15, 2023
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
johscheuer
commented
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MacOS errors seem to be an issues with the CI infrastructure? CC @ammolitor
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10885 added support for the proxy parameter in the backup_agent but the proxy was not passed down to all calls properly. This PR makes sure we use the proxy if specified. For better debugging I added the proxy value to some TraceEvents.
The PR is against 7.1 as I tested the setup with 7.1. Once the changes are approved I can open a PR against main, 7.3 and 7.2.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)