New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release-7.1] Storage-Queue-Aware GetTeam #10905
Merged
jzhou77
merged 9 commits into
apple:release-7.1
from
kakaiu:support-dd-team-get-worse-ssqueue
Sep 20, 2023
Merged
[Release-7.1] Storage-Queue-Aware GetTeam #10905
jzhou77
merged 9 commits into
apple:release-7.1
from
kakaiu:support-dd-team-get-worse-ssqueue
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is TCTeamInfo::getMovingInStorageQueueAwareShardCounterMax()
used for persisted shard info? We may not need it, can we keep only the one for max storage queue?
kakaiu
force-pushed
the
support-dd-team-get-worse-ssqueue
branch
from
September 15, 2023 23:25
a60b5ca
to
160ce01
Compare
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
kakaiu
changed the title
Support DD getTeam to check the longest storage queue size of a team
Storage-Queue-Size Aware GetTeam
Sep 15, 2023
kakaiu
force-pushed
the
support-dd-team-get-worse-ssqueue
branch
from
September 15, 2023 23:53
47cb55e
to
960aa9b
Compare
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
liquid-helium
previously approved these changes
Sep 19, 2023
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
jzhou77
previously approved these changes
Sep 19, 2023
jzhou77
approved these changes
Sep 19, 2023
liquid-helium
approved these changes
Sep 19, 2023
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
kakaiu
changed the title
Storage-Queue-Aware GetTeam
[Release-7.1] Storage-Queue-Aware GetTeam
Sep 20, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When get a dest team, we want to choose a team which does not have too long storage queue. In this PR, we set a threshold for the storage queue when getTeam(). If the longest storage queue of a team is over 1/3 of the
TARGET_BYTES_PER_STORAGE_SERVER
, this team will not be selected as the destination for any split/rebalancing data move. We should note that it is possible that getTeam may not be able to select any team when worrying the storage queue length. To address this issue, we simply retry getTeam without storage-queue-aware.To use this feature: set ENABLE_STORAGE_QUEUE_AWARE_TEAM_SELECTION=true.
Concerns:
100K correctness test with feature off:
20230919-201949-zhewang-a68ecb6a730a89cc compressed=True data_size=24072497 duration=4834855 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=1:10:35 sanity=False started=100000 stopped=20230919-213024 submitted=20230919-201949 timeout=5400 username=zhewang
100K correctness test with feature on:
20230919-201816-zhewang-a10e5909327ce756 compressed=True data_size=24072495 duration=4847303 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=1:09:10 sanity=False started=100000 stopped=20230919-212726 submitted=20230919-201816 timeout=5400 username=zhewang
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)