[Release-7.1] Add Manual Shard Split #10909

kakaiu · 2023-09-19T04:37:30Z

This PR implements fdbcli: redistribute <BeginKey> <EndKey>. The input range is passed to data distributor and DD issues data moves including all data within the range. Suppose current shard boundary is [a, c), [c, d), [d, f) and the input range is [b, d), the DD splits the shard [a, c) into [a, b) and [b, c) and triggers data moves for [a, b), [b, c), and [c, d).

100K correctness test:
20230923-200049-zhewang-a2ab10ff266a2d92 compressed=True data_size=24112130 duration=4887150 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=0:56:16 sanity=False started=100000 stopped=20230923-205705 submitted=20230923-200049 timeout=5400 username=zhewang

100K ManualShardSplit test:
20230924-004553-zhewang-70bf59bc9d72a8b7 compressed=True data_size=24111795 duration=4863033 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=0:53:25 sanity=False started=100000 stopped=20230924-013918 submitted=20230924-004553 timeout=5400 username=zhewang

Tested by Kubernetes cluster.

Limitation:
Although this PR guarantees to trigger data moves for the splitting, the data moves are not always complete. Sometimes, data moves are aborted due to DD restarts or too many data moves in the source server. For any shard that has triggered data moves but the data moves are failed to complete, this PR does not re-issue the data moves for those shards. We may need to persist and monitor the progress of the data redistribution.

Concerns:
What if too many ranges are included? DDQueue can drop data moves if src is overloaded by data moves.
It is possible that a move is issued but get aborted for some reason. Do we want to re-issue the data move if any move gets aborted? -- persist data moves until data moves complete.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci · 2023-09-19T04:53:42Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 40fef68
Duration 0:16:05
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T04:58:42Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 40fef68
Duration 0:21:02
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T05:40:56Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: f0c8226
Duration 0:16:34
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T05:41:39Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 40fef68
Duration 1:04:00
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T05:58:25Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 40fef68
Duration 1:20:42
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T06:09:30Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f0c8226
Duration 0:45:06
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T06:30:37Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f0c8226
Duration 1:06:16
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T06:51:00Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 40fef68
Duration 2:13:22
Result: ❌ FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-19T07:33:42Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f0c8226
Duration 2:09:19
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-19T21:52:26Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: cab33d7
Duration 0:04:20
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T21:52:30Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: cab33d7
Duration 0:04:22
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T21:52:31Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: cab33d7
Duration 0:04:24
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-19T21:53:40Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: cab33d7
Duration 0:05:31
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T21:53:44Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: cab33d7
Duration 0:05:40
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T22:22:19Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 3780244
Duration 0:15:36
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T22:28:24Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 3780244
Duration 0:21:40
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T22:39:14Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: b94052a
Duration 0:16:36
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T23:03:34Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 3780244
Duration 0:56:52
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T23:14:47Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: b94052a
Duration 0:52:08
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T23:20:39Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 3780244
Duration 1:13:55
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-19T23:34:27Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: b94052a
Duration 1:11:45
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-20T00:20:47Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: b94052a
Duration 1:58:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-20T01:07:10Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 3780244
Duration 3:00:30
Result: ❌ FAILED
Error: Build has timed out.
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-20T17:57:08Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 9892151
Duration 0:59:41
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T04:48:06Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: a03faa2
Duration 0:17:01
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T04:52:47Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: a03faa2
Duration 0:21:45
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T05:10:07Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 599dfa3
Duration 0:04:59
Result: ❌ FAILED
Error: Error while executing command: cmake -S . -B build_output -D USE_CCACHE=ON -D USE_WERROR=ON -D RocksDB_ROOT=/opt/rocksdb-8.1.1 -D RUN_JUNIT_TESTS=ON -D RUN_JAVA_INTEGRATION_TESTS=ON -D BUILD_DOCUMENTATION=ON -D BUILD_AWS_BACKUP=ON -G Ninja. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T05:21:59Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 599dfa3
Duration 0:16:54
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T05:26:10Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 599dfa3
Duration 0:21:07
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T05:26:39Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: a03faa2
Duration 0:55:39
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T05:42:34Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: a03faa2
Duration 1:11:30
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T06:24:14Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 599dfa3
Duration 1:19:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T06:37:51Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: a03faa2
Duration 2:06:51
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-23T07:07:00Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 599dfa3
Duration 2:01:58
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-23T21:13:15Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: cfeaa31
Duration 0:08:55
Result: ❌ FAILED
Error: reference not found for primary source and source version cfeaa316c7c0e202b3027e8f9ab34f999b1227ff
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T21:13:37Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: cfeaa31
Duration 0:09:17
Result: ❌ FAILED
Error: reference not found for primary source and source version cfeaa316c7c0e202b3027e8f9ab34f999b1227ff
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T21:13:44Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: cfeaa31
Duration 0:09:21
Result: ❌ FAILED
Error: reference not found for primary source and source version cfeaa316c7c0e202b3027e8f9ab34f999b1227ff
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-23T21:15:15Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 98f1be8
Duration 0:16:30
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T21:20:08Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 98f1be8
Duration 0:21:24
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T22:08:50Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 229b237
Duration 1:03:16
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T22:09:48Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 98f1be8
Duration 1:11:07
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T22:11:46Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 98f1be8
Duration 1:13:02
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T22:16:50Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 229b237
Duration 1:11:14
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-09-23T22:36:47Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 98f1be8
Duration 1:38:04
Result: ❌ FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-09-23T23:07:09Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 229b237
Duration 2:01:29
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

jzhou77

LGTM

jzhou77 · 2023-09-25T17:08:02Z

fdbserver/DataDistributionTracker.actor.cpp

+		splitMetrics.iosPerKSecond = splitMetrics.infinity;
+		splitMetrics.bytesReadPerKSecond = splitMetrics.infinity; // Don't split by readBandwidth
+
+		Standalone<VectorRef<KeyRef>> splitKeys_ = wait(getSplitKeys(self, keys, splitMetrics, metrics));


Nit: these two lines can be replaced with

wait(store(splitKeys, getSplitKeys(self, keys, splitMetrics, metrics)));

kakaiu requested a review from liquid-helium September 19, 2023 04:37

kakaiu force-pushed the add-manual-shard-split branch from 40fef68 to f0c8226 Compare September 19, 2023 05:24

kakaiu marked this pull request as ready for review September 19, 2023 22:22

kakaiu force-pushed the add-manual-shard-split branch from b94052a to 9892151 Compare September 20, 2023 16:57

kakaiu requested review from jzhou77 and halfprice September 20, 2023 16:59

kakaiu force-pushed the add-manual-shard-split branch from b9e42f2 to a03faa2 Compare September 23, 2023 04:30

fix issues for corner cases

599dfa3

kakaiu force-pushed the add-manual-shard-split branch from a03faa2 to 599dfa3 Compare September 23, 2023 05:04

kakaiu force-pushed the add-manual-shard-split branch from 98f1be8 to cfeaa31 Compare September 23, 2023 21:04

add more trace events

229b237

kakaiu force-pushed the add-manual-shard-split branch from cfeaa31 to 229b237 Compare September 23, 2023 21:05

liquid-helium approved these changes Sep 25, 2023

View reviewed changes

jzhou77 approved these changes Sep 25, 2023

View reviewed changes

jzhou77 merged commit 68d8799 into apple:release-7.1 Sep 25, 2023
3 checks passed

[Release-7.1] Add Manual Shard Split #10909

[Release-7.1] Add Manual Shard Split #10909

Conversation

kakaiu commented Sep 19, 2023 • edited

Code-Reviewer Section

For Release-Branches

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Sep 19, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Sep 20, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Sep 20, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Sep 20, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr on Linux CentOS 7

foundationdb-ci commented Sep 23, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

kakaiu commented Sep 19, 2023 •

edited