-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable mutation tracking work with encryption #11068
Merged
kakaiu
merged 1 commit into
apple:main
from
kakaiu:enable-mutation-tracking-work-with-encrption
Nov 16, 2023
Merged
Enable mutation tracking work with encryption #11068
kakaiu
merged 1 commit into
apple:main
from
kakaiu:enable-mutation-tracking-work-with-encrption
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
jzhou77
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
5 tasks
kakaiu
added a commit
to kakaiu/foundationdb
that referenced
this pull request
Nov 17, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce ENABLE_MUTATION_TRACKING_WITH_BLOB_CIPHER.
Current encryption does not work well with mutation tracking.
We often use mutation tracking to understand to mutation path when we find some bug in simulation tests. However, when the mutation text gets encrypted, mutation tracking does not work in TLog, as TLog does not decrypt the mutation.
We may want to decrypt the mutation at the time when we enable mutation tracking. However, this requires to introduce a
wait
which will break the determinism of the simulation. This PR address this issue by bypassing the encryption mechanism and using plain text in the mutation with the encryption mutation structure. As a result, we do not need anywait
to decrypt the mutation.A use case - debugging region corruption #11066
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)