New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release-7.1] Fix checkAll command #11138
Conversation
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
@@ -279,21 +279,20 @@ ACTOR Future<bool> checkallCommandActor(Database cx, std::vector<StringRef> toke | |||
state bool checkAll = false; // do not return on first error, continue checking all keys | |||
state KeyRange toCheck = backupLogKeys; | |||
|
|||
if (tokens.size() == 2 && tokens[1] == "ALL"_sr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to retain this checkall ALL
setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkall ALL runs checking on backupLogKeys, which is supported by the new input.
Result of foundationdb-pr-clang on Linux CentOS 7
|
Replace this text with your description here...
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)