New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release-7.1] Fix tester stale interface issue at CC #11149
Merged
jzhou77
merged 1 commit into
apple:release-7.1
from
kakaiu:fix-tester-stale-interface-at-cc
Jan 30, 2024
Merged
[Release-7.1] Fix tester stale interface issue at CC #11149
jzhou77
merged 1 commit into
apple:release-7.1
from
kakaiu:fix-tester-stale-interface-at-cc
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakaiu
changed the title
Fix tester stale interface issue at CC
[Release-7.1] Fix tester stale interface issue at CC
Jan 26, 2024
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
liquid-helium
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
jzhou77
approved these changes
Jan 27, 2024
johscheuer
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Can we make sure those changes are included in 7.3 + main?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workerAvailabilityWatch is an actor spawned when a new worker is registered to CC. However, the tester (ProcessClass::TesterClass) is ignored in workerAvailabilityWatch. For the removed tester, the corresponding worker has registered to CC but no workerAvailabilityWatch is monitoring the availability of the tester. Therefore, CC does not get notified when the tester has been physically removed and CC still keeps the worker interface. In clusterGetStatus(), CC still contacts to the removed tester but failed. Then, the removed worker interface is added to mergeUnreachable. Finally, "unreachable_processes" message is produced in the status json.
500K Correctness test:
20240126-235133-zhewang-f5c68b34cb706909 compressed=True data_size=24309527 duration=21796697 ended=500000 fail=1 fail_fast=10 max_runs=500000 pass=499999 priority=100 remaining=0 runtime=2:05:59 sanity=False started=500000 stopped=20240127-015732 submitted=20240126-235133 timeout=5400 username=zhewang
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)