Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-7.1] Upgrade to RocksDB 8.10.0. #11176

Merged
merged 4 commits into from Feb 8, 2024

Conversation

yao-xiao-github
Copy link
Contributor

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 2a21da2
  • Duration 0:18:04
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

This comment was marked as outdated.

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 2a21da2
  • Duration 0:45:22
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 2a21da2
  • Duration 1:18:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 2a21da2
  • Duration 2:45:49
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 2a21da2
  • Duration 0:04:53
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 2a21da2
  • Duration 0:21:01
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 2a21da2
  • Duration 0:43:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@ammolitor
Copy link
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 2a21da2
  • Duration 0:04:53
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
ccache /usr/local/bin/clang++ -DBOOST_CONTEXT_NO_LIB -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_SYSTEM_NO_DEPRECATED -I/codebuild/output/src3910874093/src/github.com/apple/foundationdb -I/codebuild/output/src3910874093/src/github.com/apple/foundationdb/build_output -I/codebuild/output/src3910874093/src/github.com/apple/foundationdb/fdbrpc/libeio -I/codebuild/output/src3910874093/src/github.com/apple/foundationdb/contrib/fmt-8.1.1/include -isystem /opt/boost_1_78_0_clang/include -stdlib=libc++ -g -std=gnu++17 -DCMAKE_BUILD -ggdb -fno-omit-frame-pointer -mavx -Wno-unknown-attributes -Wall -Wextra -Wredundant-move -Wpessimizing-move -Woverloaded-virtual -Wshift-sign-overflow -Wno-sign-compare -Wno-undefined-var-template -Wno-unknown-warning-option -Wno-unused-parameter -Wno-constant-logical-operand -Wno-register -Wno-unused-command-line-argument -Wno-error=format -Wunused-variable -Wno-deprecated -fvisibility=hidden -Wreturn-type -fPIC -DHAVE_OPENSSL -pthread -MD -MT fdbrpc/CMakeFiles/fdbrpc.dir/AsyncFileCached.actor.cpp.o -MF fdbrpc/CMakeFiles/fdbrpc.dir/AsyncFileCached.actor.cpp.o.d -o fdbrpc/CMakeFiles/fdbrpc.dir/AsyncFileCached.actor.cpp.o -c /codebuild/output/src3910874093/src/github.com/apple/foundationdb/fdbrpc/AsyncFileCached.actor.cpp
distcc[5349] ERROR: compile /codebuild/output/src3910874093/src/github.com/apple/foundationdb/fdbrpc/AsyncFileCached.actor.cpp on distcc-c0afcb341c31fb8c.elb.us-west-2.amazonaws.com/96 failed
distcc[5349] (dcc_build_somewhere) Warning: remote compilation of '/codebuild/output/src3910874093/src/github.com/apple/foundationdb/fdbrpc/AsyncFileCached.actor.cpp' failed, retrying locally
distcc[5349] Warning: failed to distribute /codebuild/output/src3910874093/src/github.com/apple/foundationdb/fdbrpc/AsyncFileCached.actor.cpp to distcc-c0afcb341c31fb8c.elb.us-west-2.amazonaws.com/96, running locally instead
distcc[5349] ERROR: compile /codebuild/output/src3910874093/src/github.com/apple/foundationdb/fdbrpc/AsyncFileCached.actor.cpp on localhost failed
In file included from /codebuild/output/src3910874093/src/github.com/apple/foundationdb/fdbrpc/AsyncFileCached.actor.cpp:21:
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/fdbrpc/AsyncFileCached.actor.h:346:11: error: no viable conversion from returned value of type 'AsyncFileCached *' to function return type 'Future<Reference<IAsyncFile>>'
                        return new AsyncFileCached(f, filename, l, pageCache);
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/flow/flow.h:810:2: note: candidate constructor not viable: no known conversion from 'AsyncFileCached *' to 'const Future<Reference<IAsyncFile>> &' for 1st argument
        Future(const Future<T>& rhs) : sav(rhs.sav) {
        ^
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/flow/flow.h:815:2: note: candidate constructor not viable: no known conversion from 'AsyncFileCached *' to 'Future<Reference<IAsyncFile>> &&' for 1st argument
        Future(Future<T>&& rhs) noexcept : sav(rhs.sav) {
        ^
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/flow/flow.h:819:2: note: candidate constructor not viable: no known conversion from 'AsyncFileCached *' to 'const Reference<IAsyncFile> &' for 1st argument
        Future(const T& presentValue) : sav(new SAV<T>(1, 0)) { sav->send(presentValue); }
        ^
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/flow/flow.h:820:2: note: candidate constructor not viable: no known conversion from 'AsyncFileCached *' to 'Reference<IAsyncFile> &&' for 1st argument
        Future(T&& presentValue) : sav(new SAV<T>(1, 0)) { sav->send(std::move(presentValue)); }
        ^
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/flow/flow.h:821:2: note: candidate constructor not viable: no known conversion from 'AsyncFileCached *' to 'Never' for 1st argument
        Future(Never) : sav(new SAV<T>(1, 0)) { sav->send(Never()); }
        ^
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/flow/flow.h:822:2: note: candidate constructor not viable: no known conversion from 'AsyncFileCached *' to 'const Error &' for 1st argument
        Future(const Error& error) : sav(new SAV<T>(1, 0)) { sav->sendError(error); }
        ^
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/flow/flow.h:826:2: note: candidate template ignored: requirement 'std::is_assignable<Reference<IAsyncFile>, AsyncFileCached *>::value' was not satisfied [with U = AsyncFileCached *]
        Future(const U&, typename std::enable_if<std::is_assignable<T, U>::value, int*>::type = 0) {}
        ^
/codebuild/output/src3910874093/src/github.com/apple/foundationdb/flow/flow.h:875:11: note: explicit constructor is not a candidate
        explicit Future(SAV<T>* sav) : sav(sav) {
                 ^
1 error generated.```

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 2a21da2
  • Duration 0:35:03
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@ammolitor ammolitor merged commit 3d6161e into apple:release-7.1 Feb 8, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants