Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go binding: do not commit read-only transactions #11366

Merged
merged 2 commits into from
May 29, 2024
Merged

Go binding: do not commit read-only transactions #11366

merged 2 commits into from
May 29, 2024

Commits on May 14, 2024

  1. Typo fix in Close() GoDoc

    @gm42
    gm42 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d52f7bf View commit details
    Browse the repository at this point in the history

  2. Do not commit read-only transactions 

    This a marginal improvement which follows the C API documentation:
> It is not necessary to commit a read-only transaction – you can simply call fdb_transaction_destroy().

Read-only transactions will be always destroyed before returning to caller,
without relying on Go garbage collection; the read-only transactions
can be destroyed so early because futures created within them must never be used
outside of them.
    @gm42
    gm42 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d1644f4 View commit details
    Browse the repository at this point in the history