Team trackers for bad teams that contain a removed servers must be cancelled #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be cancelled or the cluster will falsely report those teams as failed
xumengpanda
reviewed
Nov 22, 2019
| @@ -2462,6 +2462,14 @@ struct DDTeamCollection : ReferenceCounted<DDTeamCollection> { | |||
| traceAllInfo(); | |||
| } | |||
|
|
|||
| for (int t = 0; t < badTeams.size(); t++) { | |||
There was a problem hiding this comment.
In case this creates slow task, we can add badTeams field into TCTeamInfo and assign badTeam to its server's TCTeamInfo. Then we can quickly cancel it.
xumengpanda
approved these changes
Nov 22, 2019
…ase-6.2 # Conflicts: # documentation/sphinx/source/release-notes.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.