Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Protocol Version From Connect Packets #4028

Draft
wants to merge 66 commits into
base: main
Choose a base branch
from
Draft

Get Protocol Version From Connect Packets #4028

wants to merge 66 commits into from

Conversation

sfc-gh-rchen
Copy link
Contributor

No description provided.

@sfc-gh-rchen
merge anoyes/stable-interface and add back in isCompatible
b42ae23
@sfc-gh-rchen
add simulator support for different process versions and ProtocolVers…
e7e1443 
…ion test
@sfc-gh-rchen
add simulator support for different process versions and ProtocolVers…
c4c5d74 
…ion test
@sfc-gh-rchen
remove clusterFilePath from test
7e47280
@sfc-gh-rchen
remove some print statements and spin lock that was used for debugging
ecf2000
@sfc-gh-rchen
draft diff protocol
c32d99a
@sfc-gh-rchen
fix stable interfaces test and corresponding changes in simulator
2a172ff
@sfc-gh-rchen
revert MultiVersionTransaction
2e2ed6d
@sfc-gh-rchen
switch to test newer incompatible version. Fix PR comments. Modify sc…
8c96763 
…hema
@sfc-gh-rchen
merge anoyes/stable-interface and add back in isCompatible
76d0027
@sfc-gh-rchen
add simulator support for different process versions and ProtocolVers…
41843f0 
…ion test
@sfc-gh-rchen
remove some print statements and spin lock that was used for debugging
b233f44
@sfc-gh-rchen
draft diff protocol
5488ff1
@sfc-gh-rchen
fix stable interfaces test and corresponding changes in simulator
bbf5bdf
@sfc-gh-rchen
revert MultiVersionTransaction
a4e1efb
@sfc-gh-rchen
switch to test newer incompatible version. Fix PR comments. Modify sc…
2f5b0be 
…hema
@sfc-gh-rchen
merge anoyes/stable-interface and add back in isCompatible
4eb20a1
@sfc-gh-rchen
fix flowtransport conflicts
1c533e7
@sfc-gh-rchen
master conflicts
545ee42
@sfc-gh-rchen
add checksum class to change checksum in the future. expose get serve…
a4ccf8c 
…r protocol api
@sfc-gh-rchen
fix merge conflicts
b066853
@sfc-gh-rchen
fix merge conflicts
f2a8687
@sfc-gh-rchen
fix unfixed conflict
156f0f2
@sfc-gh-rchen
fix unfixed conflicts again
340e21f
@sfc-gh-rchen
change IChecksum interface and remove coordinator protocol version op…
d19918d 
…tional
@sfc-gh-rchen
change IChecksum interface and remove coordinator protocol version op…
c84a5f4 
…tional
@sfc-gh-rchen
comment checksum functions
847b724
@sfc-gh-rchen
add function to get correct checksum class. Remove IChecksum::checkSu…
90caa24 
…m function
@sfc-gh-rchen
conflicts
055add9
@sfc-gh-rchen
add unit test and some cleanup
309e38d
@sfc-gh-rchen sfc-gh-rchen reopened this Nov 6, 2020
@sfc-gh-rchen
modify getConnectPktVersions to wait for any change. Add loop for coo…
86db7aa 
…rd protocol request to keep connections open so connect packets are sent
@sfc-gh-rchen sfc-gh-rchen force-pushed the get_protocol_before_stable_interface branch from 18f77ab to 86db7aa Compare November 9, 2020 06:02
sfc-gh-anoyes
sfc-gh-anoyes reviewed Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@sfc-gh-anoyes sfc-gh-anoyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test new flow transport logic in the test where we have a fdbserver with a different protocol version

fdbclient/NativeAPI.actor.cpp Outdated Show resolved Hide resolved
@sfc-gh-rchen
fix redundant code and change protocol version test to call getCoordi…
30b6dda 
…natorProtocols function
@sfc-gh-rchen
conflicts
3239d8e
@sfc-gh-rchen
merge conflicts
7fad204
@sfc-gh-rchen
Merge branch 'master' of https://github.com/apple/foundationdb into g…
3d3b4e2 
…et_protocol_before_stable_interface
@sfc-gh-rchen
Merge branch 'master' of https://github.com/apple/foundationdb into g…
052bf2e 
…et_protocol_expected_version
@sfc-gh-rchen
initial get server protocol expected version and run one client in mu…
2bc97d4 
…ltiversion client and add clients on the fly
@sfc-gh-rchen
fix branch
6d3813d
@sfc-gh-rchen
merge conflicts
c77d9e4
@sfc-gh-rchen
set transport id to zero, revert externalClient key change, add unit …
140018c 
…test
@sfc-gh-rchen
Merge branch 'get_protocol_expected_version' of https://github.com/sf…
b6f55ed 
…c-gh-rchen/foundationdb into get_protocol_before_stable_interface
@sfc-gh-rchen
Merge branch 'master' of https://github.com/apple/foundationdb into g…
ba4ba65 
…et_protocol_before_stable_interface
@sfc-gh-rchen
fix create_database with no arguments bug
f2a7c2f
@sfc-gh-rchen
fix typo in python
b4ea824
@sfc-gh-rchen
conflicts
5579ce0
@sfc-gh-rchen
Merge branch 'master' of https://github.com/apple/foundationdb into g…
fbd4c43 
…et_protocol_before_stable_interface
@sfc-gh-rchen
switch to thread futures and add in logic to between compatible clients
ef85153
@sfc-gh-rchen
Merge branch 'master' of https://github.com/apple/foundationdb into g…
7d3913e 
…et_protocol_before_stable_interface
@sfc-gh-rchen
put get protocol request on main thread
da448be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-anoyes sfc-gh-anoyes sfc-gh-anoyes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-rchen @sfc-gh-anoyes