Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on Windows using VS 2019 + LLVM/Clang #4258

Merged
merged 7 commits into from Jan 31, 2021
Merged

Build on Windows using VS 2019 + LLVM/Clang #4258

merged 7 commits into from Jan 31, 2021

Commits on Jan 30, 2021

  1. winbuild: do not use reserved keyword 'interface' for variable name 

    - renamed variable so as not to use a reserved keyword.
    @KrzysFR
    KrzysFR committed Jan 30, 2021
    Copy the full SHA
    f59b2b2 View commit details
    Browse the repository at this point in the history

  2. winbuild: fix int argc for main() 

    - fix compile error requiring first arg of main() to be of type int
    @KrzysFR
    KrzysFR committed Jan 30, 2021
    Copy the full SHA
    89735f7 View commit details
    Browse the repository at this point in the history

  3. winbuild: use _strnicmp instead of strnicmp

    @KrzysFR
    KrzysFR committed Jan 30, 2021
    Copy the full SHA
    5d2a7cd View commit details
    Browse the repository at this point in the history

  4. winbuild: fix passing std::string directly to format(...) 

    - pass result of c_str() instead
    @KrzysFR
    KrzysFR committed Jan 30, 2021
    Copy the full SHA
    0eeb738 View commit details
    Browse the repository at this point in the history

  5. winbuild: fix const_cast<char*> issue

    @KrzysFR
    KrzysFR committed Jan 30, 2021
    Copy the full SHA
    3cef471 View commit details
    Browse the repository at this point in the history

  6. winbuild: define BOOST_USE_WINDOWS_H, WIN32_LEAN_AND_MEAN and NOMINMA… 

    …X to fix various macro expansions issues

- NOMINMAX to fix confusion between std::max(..) and max(..) macro redefinition
- BOOST_USE_WINDOWS_H to prevent boost from redefining win32 APIs
- WIN32_LEAN_AND_MEAN to fix include ordering issues with winsock.h
    @KrzysFR
    KrzysFR committed Jan 30, 2021
    Copy the full SHA
    ff0667b View commit details
    Browse the repository at this point in the history

  7. winbuild: fix duplicate definition of Codec<ERestoreState>::pack and … 

    …unpack in Debug build

- defined twice in FileBackupAgent.actor.cpp and BackupAgent.actor.h
- only fails when building in Debug ?
    @KrzysFR
    KrzysFR committed Jan 30, 2021
    Copy the full SHA
    3fc8870 View commit details
    Browse the repository at this point in the history