Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: skip jemalloc on FreeBSD #4373

Merged

Conversation

dch
Copy link
Contributor

@dch dch commented Feb 22, 2021

FreeBSD is the upstream for jemalloc so it's the system malloc already.

See #4222 for previous jemalloc work.

Changes in this PR:

  • move WIN32 comment to where the relevant code is
  • exclude jemalloc if OS==FreeBSD

Style

  • n/a

Performance

  • n/a

Testing

  • still waiting on FreeBSD builds to complete

FreeBSD is the upstream for jemalloc so it's the system malloc already
@dch
Copy link
Contributor Author

dch commented Feb 24, 2021

LGTM, builds on FreeBSD 12.2-RELEASE & 13.0-BETA3 and 14.0-CURRENT just for funsies.

@dch dch marked this pull request as ready for review February 24, 2021 16:23
@sfc-gh-mpilman sfc-gh-mpilman merged commit dd56261 into apple:master Mar 1, 2021
@dch dch deleted the fix/freebsd-use-default-allocator branch May 31, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants