rewrote tlog recruitment logic so that it is deterministic #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t better master exists from triggering spuriously
AWS CodeBuild CI Report
|
…max commit latency, because it can be spuriously triggered by dummy transactions that take 5+ seconds each
AWS CodeBuild CI Report
|
…mulation because it is the recommended process class, and the others are not deterministic when recruited in a constrained process situation
… amount of time a commit takes because of long commit times
…ys share with the same other role when everything else is equal
… just the worst one. Since this is a behavior change from the backup recruitment, we cannot compared degraded between the two recruitments
fix: tlog recruitment did not attempt to avoid longLivedStateless processes
…recruitment is deterministic
…s the same as GrvProxyClass now
…e enum the same between versions
sfc-gh-mpilman
approved these changes
Apr 27, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this rewrite is to prevent better master exists from triggering spuriously because tlogs randomly get located on different processes each time the function is called.
Changing the recruitment logic also has the benefit that now the cluster controller will ensure Log class processes are recruited before Transaction class processes.
Passed: 934930
Failed: 10
Failing tests:
RandomSeed="994272039" BuggifyEnabled="1" TestFile="tests/slow/SwizzledCycleTest.toml"
TooManyFiles
RandomSeed="325685976" BuggifyEnabled="1" TestFile="tests/slow/FastTriggeredWatches.toml"
Test timed out
RandomSeed="58742398" BuggifyEnabled="1" TestFile="tests/fast/SwizzledRollbackSideband.toml"
Error starting workload
JoshuaMessage Severity="40" Error="JoshuaTimeout" TimeoutCommandRun="true" PythonError="Command './joshua_timeout' timed out after 180 seconds”
RandomSeed="199525603" BuggifyEnabled="1" TestFile="tests/rare/CloggedCycleWithKills.toml"
RecoveryDelayedTooManyOldGenerations
RandomSeed="228055023" BuggifyEnabled="1" OldBinary="fdbserver" TestFile="tests/restarting/from_7.0.0/ConfigureTestRestart-1.txt"
RandomSeed="228055024" BuggifyEnabled="1" OldBinary="fdbserver" TestFile="tests/restarting/from_7.0.0/ConfigureTestRestart-2.txt"
TesterRecruitmentTimeout
RandomSeed="224073052" BuggifyEnabled="0" OldBinary="fdbserver" TestFile="tests/restarting/from_6.2.29/SnapTestAttrition-1.txt"
SetupAndRunError Error="timed_out"
RandomSeed="5142395" BuggifyEnabled="1" OldBinary="fdbserver" TestFile="tests/restarting/from_7.0.0/SnapIncrementalRestore-1.toml"
TestFailure Error="timed_out"
RandomSeed="699167286" BuggifyEnabled="1" TestFile="tests/fast/TxnStateStoreCycleTest.toml"
TooManyFiles
RandomSeed="854128356" BuggifyEnabled="1" OldBinary="fdbserver" TestFile="tests/restarting/from_7.0.0/SnapIncrementalRestore-1.toml"
TestFailure Error="timed_out"
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormasterif this is the youngest branch)