Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick "add MasterMetrics periodic logging" to 6.3. #4829

Merged
merged 1 commit into from Jun 8, 2021

Conversation

RenxuanW
Copy link
Contributor

@RenxuanW RenxuanW commented May 17, 2021

Cherrypicking #4626. Add logging to master role to count the number of requests of each type received. This helps to determine whether the master is making progress. We need it in 6.3 to debug master-stall issues.

20210608-205053-renxuan-8cec4d1d58f255fb compressed=True data_size=21416213 duration=4360671 ended=102460 fail_fast=10 max_runs=100000 pass=100001 priority=100 remaining=0 runtime=0:29:03 sanity=False started=102565 stopped=20210608-211956 submitted=20210608-205053 timeout=5400 username=renxuan

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@RenxuanW RenxuanW linked an issue May 17, 2021 that may be closed by this pull request
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 6dcf863
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 9d7d3e1
  • Result: FAILED
  • Build Logs (available for 7 days)

halfprice
halfprice previously approved these changes May 18, 2021
Copy link
Contributor

@halfprice halfprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure the CodeBuild pass?

@RenxuanW
Copy link
Contributor Author

Can you make sure the CodeBuild pass?

It's an unrelated failure. I just ran the test locally, it passed.

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 529a3a4
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 1170cba
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 33355a8
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: f17a49d
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@RenxuanW RenxuanW merged commit c9c0f80 into apple:release-6.3 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cherry-pick MasterMetrics PR into 6.3 branch
5 participants