New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick "add MasterMetrics periodic logging" to 6.3. #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
|
AWS CodeBuild CI Report
|
halfprice
previously approved these changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure the CodeBuild pass?
It's an unrelated failure. I just ran the test locally, it passed. |
AWS CodeBuild CI Report
|
sfc-gh-tclinkenbeard
previously approved these changes
May 24, 2021
RenxuanW
force-pushed
the
release-6.3
branch
2 times, most recently
from
June 8, 2021 19:14
1170cba
to
f17a49d
Compare
AWS CodeBuild CI Report
|
AWS CodeBuild CI Report
|
AWS CodeBuild CI Report
|
xumengpanda
approved these changes
Jun 8, 2021
halfprice
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicking #4626. Add logging to master role to count the number of requests of each type received. This helps to determine whether the master is making progress. We need it in 6.3 to debug master-stall issues.
20210608-205053-renxuan-8cec4d1d58f255fb compressed=True data_size=21416213 duration=4360671 ended=102460 fail_fast=10 max_runs=100000 pass=100001 priority=100 remaining=0 runtime=0:29:03 sanity=False started=102565 stopped=20210608-211956 submitted=20210608-205053 timeout=5400 username=renxuan
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormaster
if this is the youngest branch)