Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed python binding classifier #601

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

AlvinMooreSr
Copy link
Contributor

Replaced python binding classifier within configuration file to one that is acceptable by pypi listed at https://pypi.org/pypi?%3Aaction=list_classifiers

@alexmiller-apple
Copy link
Contributor

Note that there's a lot of conversation on the topic of the lack of specifically apache v2 in pypa/pypi-legacy #91 and pypa/warehouse #2996.

@davelester
Copy link
Contributor

+1, thanks @AlvinMooreSr!

PyPI describes the use of classifiers, and says they can "be used by community members to find projects based on their desired criteria." Sounds like their function is essentially for discovery of repos.

With that in mind, this change looks good and ready to merge with a few minor caveats if this PR is ever revisited:

  1. the LICENSE file in the project root and license headers on individual Python binding files should remain Apache v2
  2. when a more-descriptive classifier exists, let's make a point to update FDB to properly reflect the specific license version [I've subscribed to pypa/warehouse #2996, but if anyone else wants to help monitor its progress and follow-up here, I'd appreciate it]

@hgray1 hgray1 assigned AlvinMooreSr and unassigned davelester Aug 13, 2018
@AlvinMooreSr AlvinMooreSr merged commit f4b3299 into apple:release-5.2 Sep 4, 2018
@AlvinMooreSr AlvinMooreSr deleted the python-setup branch June 19, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants