Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.3] Use CC_ENABLE_WORKER_HEALTH_MONITOR knob to guard remoteDCIsHealthy logic #6106

Merged

Conversation

halfprice
Copy link
Contributor

Cherry pick #6105

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 4a8c511
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

Copy link
Contributor

@RenxuanW RenxuanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history doesn't look correct.

@xumengpanda xumengpanda changed the base branch from master to release-6.3 December 6, 2021 12:15
Copy link
Contributor

@xumengpanda xumengpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after change the PR against 6.3 instead of master.

@halfprice
Copy link
Contributor Author

LGTM after change the PR against 6.3 instead of master.

Thank you!

@jzhou77 jzhou77 merged commit 1a9bec0 into apple:release-6.3 Dec 6, 2021
@halfprice halfprice deleted the zhewu/fix-remote-monitor-flag-6.3 branch December 6, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants