Introduce multi-threaded/multi-version client support for GRV caching #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for macOS BigSur 11.5.2
|
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for Linux CentOS 7
|
…ocolVersion instead of piping version through function parameters
…he-multi-threaded
AWS CodeBuild CI Report for Linux CentOS 7
|
Doxense CI Report for Windows 10
|
…from a null value
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for macOS BigSur 11.5.2
|
AWS CodeBuild CI Report for Linux CentOS 7
|
| @@ -233,10 +252,18 @@ void DatabaseContext::updateCachedReadVersion(double t, Version v) { | |||
| } | |||
|
|
|||
| Version DatabaseContext::getCachedReadVersion() { | |||
| if (sharedStatePtr) { | |||
| MutexHolder mutex(sharedStatePtr->mutexLock); | |||
There was a problem hiding this comment.
I would suggest to plan a follow up task to optimize synchonization on the global cachedReadVersion. Mutex gives a reliable implementation, but it can introduce a significant overhead in a configuration with multiple FDB threads. I think we can replace mutex with atomics. It is not completely trivial, because the cachedReadVersion and lastGrvTime must be updated atomically, but it is doable. We can discuss it after you are done with this PR.
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for macOS BigSur 11.5.2
|
Doxense CI Report for Windows 10
|
AWS CodeBuild CI Report for Linux CentOS 7
|
|
Testing done: 100k correctness passed at |
sfc-gh-vgasiunas
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #5725 and adds functionality to the
fdb_candMultiVersionApirelated interfaces to support GRV caching behaving as expected, especially in commit->read (your own commits) patterns when there are multiple connections to the same cluster. The correctness is tested through the C API framework for multi-threaded operations introduced by #6433, enabled by setting the transaction option to use the GRV cache within the existing tests.Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormasterif this is the youngest branch)