fdbmonitor: track parent process death for FreeBSD

[dwagin]

Track parent process death for FreeBSD.

Before: When dbmonitor terminated, the children continued to work.
After: Children receive a SIGHUP signal and finish their work.

Also fixed sigprocmask() restore.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

• The PR has a description, explaining both the problem and the solution.
• The description mentions which forms of testing were done and the testing seems reasonable.
• Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

• This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
• There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: 713fce3
• Duration 0:16:46
• Result: ❌ FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: 713fce3
• Result: ✔️ SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

• Commit ID: 713fce3
• Duration 0:50:39
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 713fce3
• Duration 2:09:18
• Result: ❌ FAILED
• Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 713fce3
• Duration 4:02:14
• Result: ❌ FAILED
• Error: Build has timed out.
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[jzhou77]

To avoid changing the behavior for MacOS, should this be included in freebsd?

[dwagin]

Imho, executing sigprocmask() only under linux is a typo.

[sfc-gh-abeamon]

It looks like the goal of this is to restore the original signal mask to the child processes, which in theory could run on all platforms. It does also seem that we don't actually change the signal mask except on Linux, so maybe this doesn't actually need to be run on anything but Linux. If we wanted to do the latter, though, it may be clearer to have this function call sigprocmask unconditionally and then have the other platforms pass in a null mask.

[drTr0jan]

@sfc-gh-abeamon, I believe, there's a moment when the signal mask can be changed on non-Linux system. load_conf() via start_process() is executed with &normal_mask on all platforms at

foundationdb/fdbmonitor/fdbmonitor.cpp

Line 1628 in 713fce3

load_conf(confpath.c_str(), uid, gid, &normal_mask, watched_fds, &maxfd);

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 713fce3
• Duration 1:36:50
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[drTr0jan]

What about to commit? @jzhou77 , @sfc-gh-abeamon ?

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 713fce3
• Duration 0:03:53
• Result: ❌ FAILED
• Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux CentOS 7

• Commit ID: 713fce3
• Duration 0:03:59
• Result: ❌ FAILED
• Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: 713fce3
• Duration 0:03:56
• Result: ❌ FAILED
• Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 713fce3
• Duration 0:04:00
• Result: ❌ FAILED
• Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)

[jzhou77]

Close because of CI failure and cloned this PR in #11361