Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file include api #109

Merged
merged 5 commits into from Sep 2, 2020
Merged

add file include api #109

merged 5 commits into from Sep 2, 2020

Conversation

woshiccm
Copy link
Contributor

No description provided.

@woshiccm
Copy link
Contributor Author

woshiccm commented Aug 28, 2020

@akyrtzi pls help to review, thx.

we want to use indexstore-db to ge file include info, but now don't provide the api, this pr add two public api

Copy link
Member

@akyrtzi akyrtzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Could you also add tests for the new APIs?

@woshiccm
Copy link
Contributor Author

Thank you for the contribution! Could you also add tests for the new APIs?

Had added test for the new APIs🍺

Copy link
Member

@akyrtzi akyrtzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks, otherwise LGTM!

Tests/IndexStoreDBTests/IndexTests.swift Outdated Show resolved Hide resolved
include/CIndexStoreDB/CIndexStoreDB.h Outdated Show resolved Hide resolved
@akyrtzi
Copy link
Member

akyrtzi commented Sep 1, 2020

@swift-ci Please test

@akyrtzi
Copy link
Member

akyrtzi commented Sep 1, 2020

@woshiccm, there is a CI failure:

/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/IndexStoreDBTests/IndexTests.swift:317: error: -[IndexStoreDBTests.IndexTests testFilesIncludes] : XCTAssertEqual failed: ("["/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/INPUTS/MainFiles/main2.c", "/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/INPUTS/MainFiles/main1.c"]") is not equal to ("["/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/INPUTS/MainFiles/main1.c", "/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/INPUTS/MainFiles/main2.c"]")

This is because the order that the includes are received is not stable from run to run. Could you change the test so that it compares sorted lists?

@woshiccm
Copy link
Contributor Author

woshiccm commented Sep 2, 2020

@woshiccm, there is a CI failure:

/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/IndexStoreDBTests/IndexTests.swift:317: error: -[IndexStoreDBTests.IndexTests testFilesIncludes] : XCTAssertEqual failed: ("["/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/INPUTS/MainFiles/main2.c", "/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/INPUTS/MainFiles/main1.c"]") is not equal to ("["/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/INPUTS/MainFiles/main1.c", "/Users/buildnode/jenkins/workspace/swift-indexstore-db-PR-macOS/branch-master/indexstore-db/Tests/INPUTS/MainFiles/main2.c"]")

This is because the order that the includes are received is not stable from run to run. Could you change the test so that it compares sorted lists?

done

@akyrtzi
Copy link
Member

akyrtzi commented Sep 2, 2020

@swift-ci Please test

@akyrtzi akyrtzi merged commit e093926 into apple:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants