New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add file include api #109
add file include api #109
Conversation
@akyrtzi pls help to review, thx. we want to use indexstore-db to ge file include info, but now don't provide the api, this pr add two public api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Could you also add tests for the new APIs?
Had added test for the new APIs🍺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nitpicks, otherwise LGTM!
@swift-ci Please test |
@woshiccm, there is a CI failure:
This is because the order that the includes are received is not stable from run to run. Could you change the test so that it compares sorted lists? |
done |
@swift-ci Please test |
No description provided.