forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 322
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #7499 from jasonmolenda/cp/modify-watchpoints
[lldb] Add 'modify' type watchpoints, make it default (llvm#66308)
- Loading branch information
Showing
32 changed files
with
393 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
%feature("docstring", | ||
"A container for options to use when creating watchpoints." | ||
) lldb::SBWatchpointOptions; | ||
|
||
%feature("docstring", "Sets whether the watchpoint should stop on read accesses." | ||
) lldb::SBWatchpointOptions::SetWatchpointTypeRead; | ||
%feature("docstring", "Gets whether the watchpoint should stop on read accesses." | ||
) lldb::SBWatchpointOptions::GetWatchpointTypeRead; | ||
%feature("docstring", "Sets whether the watchpoint should stop on write accesses. eWatchpointWriteTypeOnModify is the most commonly useful mode, where lldb will stop when the watched value has changed. eWatchpointWriteTypeAlways will stop on any write to the watched region, even if it's the value is the same." | ||
) lldb::SBWatchpointOptions::SetWatchpointTypeWrite; | ||
%feature("docstring", "Gets whether the watchpoint should stop on write accesses, returning WatchpointWriteType to indicate the type of write watching that is enabled, or eWatchpointWriteTypeDisabled." | ||
) lldb::SBWatchpointOptions::GetWatchpointTypeWrite; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
//===-- SBWatchpointOptions.h -----------------------------------*- C++ -*-===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef LLDB_API_SBWATCHPOINTOPTIONS_H | ||
#define LLDB_API_SBWATCHPOINTOPTIONS_H | ||
|
||
#include "lldb/API/SBDefines.h" | ||
|
||
class WatchpointOptionsImpl; | ||
|
||
namespace lldb { | ||
|
||
class LLDB_API SBWatchpointOptions { | ||
public: | ||
SBWatchpointOptions(); | ||
|
||
SBWatchpointOptions(const lldb::SBWatchpointOptions &rhs); | ||
|
||
~SBWatchpointOptions(); | ||
|
||
const SBWatchpointOptions &operator=(const lldb::SBWatchpointOptions &rhs); | ||
|
||
/// Stop when the watched memory region is read. | ||
void SetWatchpointTypeRead(bool read); | ||
bool GetWatchpointTypeRead() const; | ||
|
||
/// Stop when the watched memory region is written to/modified | ||
void SetWatchpointTypeWrite(lldb::WatchpointWriteType write_type); | ||
lldb::WatchpointWriteType GetWatchpointTypeWrite() const; | ||
|
||
private: | ||
// This auto_pointer is made in the constructor and is always valid. | ||
mutable std::unique_ptr<WatchpointOptionsImpl> m_opaque_up; | ||
}; | ||
|
||
} // namespace lldb | ||
|
||
#endif // LLDB_API_SBWATCHPOINTOPTIONS_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
//===-- SBWatchpointOptions.cpp -------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "lldb/API/SBWatchpointOptions.h" | ||
#include "lldb/Breakpoint/Watchpoint.h" | ||
#include "lldb/Utility/Instrumentation.h" | ||
|
||
#include "Utils.h" | ||
|
||
using namespace lldb; | ||
using namespace lldb_private; | ||
|
||
class WatchpointOptionsImpl { | ||
public: | ||
bool m_read = false; | ||
bool m_write = false; | ||
bool m_modify = false; | ||
}; | ||
|
||
|
||
SBWatchpointOptions::SBWatchpointOptions() | ||
: m_opaque_up(new WatchpointOptionsImpl()) { | ||
LLDB_INSTRUMENT_VA(this); | ||
} | ||
|
||
SBWatchpointOptions::SBWatchpointOptions(const SBWatchpointOptions &rhs) { | ||
LLDB_INSTRUMENT_VA(this, rhs); | ||
|
||
m_opaque_up = clone(rhs.m_opaque_up); | ||
} | ||
|
||
const SBWatchpointOptions & | ||
SBWatchpointOptions::operator=(const SBWatchpointOptions &rhs) { | ||
LLDB_INSTRUMENT_VA(this, rhs); | ||
|
||
if (this != &rhs) | ||
m_opaque_up = clone(rhs.m_opaque_up); | ||
return *this; | ||
} | ||
|
||
SBWatchpointOptions::~SBWatchpointOptions() = default; | ||
|
||
void SBWatchpointOptions::SetWatchpointTypeRead(bool read) { | ||
m_opaque_up->m_read = read; | ||
} | ||
bool SBWatchpointOptions::GetWatchpointTypeRead() const { | ||
return m_opaque_up->m_read; | ||
} | ||
|
||
void SBWatchpointOptions::SetWatchpointTypeWrite( | ||
WatchpointWriteType write_type) { | ||
if (write_type == eWatchpointWriteTypeOnModify) { | ||
m_opaque_up->m_write = false; | ||
m_opaque_up->m_modify = true; | ||
} else if (write_type == eWatchpointWriteTypeAlways) { | ||
m_opaque_up->m_write = true; | ||
m_opaque_up->m_modify = false; | ||
} else | ||
m_opaque_up->m_write = m_opaque_up->m_modify = false; | ||
} | ||
|
||
WatchpointWriteType SBWatchpointOptions::GetWatchpointTypeWrite() const { | ||
if (m_opaque_up->m_modify) | ||
return eWatchpointWriteTypeOnModify; | ||
if (m_opaque_up->m_write) | ||
return eWatchpointWriteTypeAlways; | ||
return eWatchpointWriteTypeDisabled; | ||
} |
Oops, something went wrong.