-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAS Unittests broken on Windows #7883
Comments
This is limiting the CAS size when running the tests. Somehow OnDiskCAS is on by default now on windows so this test is actually getting run. I think I just remove this piece of code for windows for CAS upstreaming but I don't think windows has test cleanly passing now with this version of OnDiskCAS implementation. I will build and verify the tests on windows before doing a simple fix. (you can just comment the entire constructor function off for now). |
Fix the CAS unit-test build for windows which doesn't have the same setenv function and constructor attributes. Implement the default ondisk cas differently so it can be overwritten from environmental variable, or overwrite the value in process directly. Fix: apple#7883
Fix the CAS unit-test build for windows which doesn't have the same setenv function and constructor attributes. Implement the default ondisk cas differently so it can be overwritten from environmental variable, or overwrite the value in process directly. Fix: apple#7883
Fix the CAS unit-test build for windows which doesn't have the same setenv function and constructor attributes. Implement the default ondisk cas differently so it can be overwritten from environmental variable, or overwrite the value in process directly. Fix: #7883
Fix the CAS unit-test build for windows which doesn't have the same setenv function and constructor attributes. Implement the default ondisk cas differently so it can be overwritten from environmental variable, or overwrite the value in process directly. Fix: #7883
The text was updated successfully, but these errors were encountered: