Merge 2020-10-28 into swift/tensorflow #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wift [lldb][swift] Only run Swift API tests when Swift support is enabled
…/tensorflow-stage * 'swift/main' of github.com:apple/llvm-project: [lldb][swift] Only run Swift API tests when Swift support is enabled
…ftEnabled [lldb][swift] Only run Swift Shell tests when Swift support is enabled
…a13cbe273500b020c4fad1252 [dwarfdump] Warn for tags with DW_CHILDREN_yes but no children.
Check that ModuleNamesBuffer is valid before attempting to read strings from it to avoid possible segfaults. Wasn't able to come up with a test case, but this does happen based on reported crashes. Also use StringRef.substr, which returns an empty string if the index is out of bounds, for even further safety. Resolves rdar://69809414
Merge bastille into main
[clang][Index] Add guard to IndexUnitReader module name reading
[Swift] Synthesized type alias should be implicit to avoid upsetting ASTScope
The swiftTest decorator should be on all Swift tests to make sure they are only run in configurations where Swift is supported. Otherwise these tests are still run and will fail when the Swift plugin is disabled.
Rename test to give it a unique name
ObjCContainerDecl.getMethod returns a nullptr by default when the container is a hidden prototype. Callsites where the method is being looked up on the redeclaration's own container should skip this check since they (rightly) expect a valid method to be found. Resolves rdar://69444243 Reviewed By: akyrtzi Differential Revision: https://reviews.llvm.org/D89024
Restore unix signal table to its original glory and mark it as not to be clang-formatted. (cherry picked from commit 0fcacef)
Except for the few people actually debugging shells, stopping on a SIGCONT doesn't add any value. And for people trying to run tests under the debugger, stopping here is actively inconvenient. So this patch switches the default behavior to not stop. Differential Revision: https://reviews.llvm.org/D89019 (cherry picked from commit a68ffb1)
Restore the signal tables to its original glory and mark it as not to be clang-formatted. (cherry picked from commit 9d7b08b)
[AST] Fix crashes caused by redeclarations in hidden prototypes
[lldb][swift] Add missing swiftTest decorators
…80dc040f4f055db6df695ac12+a68ffb19d392c6d52f6e42925217a77b4cd71cee+9d7b08bd0657688c186b5b3d39512c484e8c37f5 Change the default handling of SIGCONT to nosuppress/nostop/notify
Transform() recursively transforms a demangle tree by doing a post-order traversal and replacing each node with fn(node). In most cases this utility will do less work than the ad-hoc implementation it is replacing because we now only recreate nodes that actually changed.
Revert "[CodeExtractor] Don't create bitcasts when inserting lifetime markers (NFCI)"
This change moves elfabi related code to llvm/InterfaceStub library so it can be shared by multiple llvm tools without causing cyclic dependencies. Differential Revision: https://reviews.llvm.org/D85678
This change removes unnecessary HEADER_DIRS from //llvm/lib/ InterfaceStub/CMakeLists.txt file. Differential Revision: https://reviews.llvm.org/D85936
It appears for Swift there was confusing errors when trying to parse APINotes, when libAPINotes and libInterfaceStub are linked, they both export symbol `__ZN4llvm4yaml7yamlizeINS_12VersionTupleEEENSt3__19enable_ifIXsr16has_ScalarTraitsIT_EE5valueEvE4typeERNS0_2IOERS5_bRNS0_12EmptyContextE`, and discovered same symbol defined within llvm-ifs. This consolidates the boilerplate into YAMLTraits and defers the specific validation in reading the whole input. fixes: rdar://problem/70450563 Reviewed By: phosek, dblaikie Differential Revision: https://reviews.llvm.org/D89764
* Its now defined in YAMLTraits, to avoid ODR violation.
Remove print statement from test that resulted in a non-deterministic…
This was skipped as it apparently regressed while the swiftTests were unintentionally disabled. I can't reproduce this failure anymore and it seems to consistently pass, so let's re-enable it.
Since commit eaceb46 AddVariableInfo is always using the dynamic type if requested. The dynamic types appear to not always be usable and caused a few tests to fail(1), but as the swiftTest decorator was always skipping all Swift tests since commit 2c911bc this wasn't discovered before landing. This patch restores the old behaviour where possible by first trying the non-dynamic type and falling back to the dynamic type in case the non-dynamic type can't be fully realized. (1) All the failures seem to be related to us reading corrupt data from memory when using the dynamic type in the expression parser. The dynamic types itself appear to be perfectly fine, so it's not clear why the new behaviour doesn't work.
[lldb] Update static bindings
[lldb][swift] Re-enable TestSwiftUnknownSelf
[lldb][swift] Use dynamic types as a fallback in AddVariableInfo
TypeSystem: silence some errors identified by MSVC
…/tensorflow-stage * 'swift/main' of github.com:apple/llvm-project: [lldb][swift] Only run Swift API tests when Swift support is enabled
… swift/tensorflow-stage * 'swift/tensorflow' of github.com:apple/llvm-project: Remove ISO646 include
Add a TypeSystemSwiftTypeRef::GetTupleElementName() method.
Fix Warnings
…/tensorflow-stage * 'swift/main' of github.com:apple/llvm-project: Fix compilation warnings Add a TypeSystemSwiftTypeRef::GetTupleElementName() method.
BradLarson
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.