Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb][swift] Ignore -- flag in swift-extra-clang-flags #2407

Open
wants to merge 1 commit into
base: swift/next
Choose a base branch
from

Conversation

Teemperor
Copy link

-- indicates to Clang that all following arguments are file names (even when
they match a Clang compiler flag). This leads to the confusion situation
where LLDB users can run settings set target.swift-extra-clang-flags -- -v
and completely break the embedded Clang instance (that now tries to open the
file -v).

Fixes rdar://58457122

(cherry picked from commit 7fd0352)

`--` indicates to Clang that all following arguments are file names (even when
they match a Clang compiler flag). This leads to the confusion situation
where LLDB users can run `settings set target.swift-extra-clang-flags -- -v`
and completely break the embedded Clang instance (that now tries to open the
file `-v`).

Fixes rdar://58457122

(cherry picked from commit 7fd0352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant