[LLDB][Swift] Use the new mangleNode() return type correctly. #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
force-pushed
the
problem/79725187
branch
2 times, most recently
from
b0c5a2f
to
73a9174
Compare
The return type of `mangleNode()` is changing to allow the remanglers to report errors to the caller. Change the LLDB plugin to account for that, and try to handle errors more reasonably (previously they would have resulted in program termination). See also apple/swift#39187 rdar://79725187
al45tair
force-pushed
the
problem/79725187
branch
from
73a9174
to
f12a880
Compare
|
Please test with the following PR: @swift-ci Please test |
adrian-prantl
approved these changes
Sep 13, 2021
|
Please test with the following PR: @swift-ci Please test |
This was referenced Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type of
mangleNode()is changing to allow the remanglers to report errors to the caller. Change the LLDB plugin to account for that, and try to handle errors more reasonably (previously they would have resulted in program termination).See also apple/swift#39187
rdar://79725187