[lldb] Make GetClangTypeNode aware of SIMD types. #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler has some special handling for SIMD types, implement the same rules on TypeSystemSwiftTypeRef on GetClangTypeNode.
augusto2112
force-pushed
the
special_rule_simd_on_clang_node
branch
from
479e65a
to
ddcaae6
Compare
|
|
||
| // Check if this is a SIMD type. For a vector this is something like | ||
| // type __attribute__((ext_vector_type(dimension))). | ||
| if (!clang_name.contains("__attribute__((ext_vector_type")) |
There was a problem hiding this comment.
Maybe it would be cleaner to use ClangUtil::GetQualType(clang_type)->hasAttr()?
| // kind=Structure | ||
| // kind=Module, text="Swift" | ||
| // kind=Identifier, text="Type" | ||
| NodePointer element_type_node = |
There was a problem hiding this comment.
Maybe factor out a static DemangleNode* GetBoundGenericStruct(Name, TypeParam)?
| NodePointer type_list = dem.createNode(Node::Kind::TypeList); | ||
| type_list->addChild(element_type_node, dem); | ||
| NodePointer identifier = | ||
| dem.createNode(Node::Kind::Identifier, "SIMD" + std::to_string(size)); |
There was a problem hiding this comment.
This is a micro-optimization that will not matter, but we could do this with fewer memory allocations by using
SmallString<6> name;
llvm::raw_string_ostream(name)<<"SIMD"<<size;
| // Check if this is a SIMD type. SIMD structs are matrixes, and they're | ||
| // in the format simd_typeNxN. | ||
| // Regex: start with simd_ and end with NxN. | ||
| std::regex simd_matrix_recognizer("^simd_.*[0-9]+x[0-9]+"); |
There was a problem hiding this comment.
IIRC, there was some supported platform that didn't have a regex implementation. Maybe grep for regex in the lldb sources. If there is no comment about it there then this is probably no longer an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler has some special handling for SIMD types, implement the
same rules on TypeSystemSwiftTypeRef on GetClangTypeNode.