[lldb] Add information on swiftmodule load times to statistics dump command
#5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Upstream portion: https://reviews.llvm.org/D137191 |
bulbazord
force-pushed
the
swift-module-load-times
branch
from
e5e61ab
to
ff68bbe
Compare
|
@swift-ci please test |
Context: I plan on using this change primarily downstream in the apple fork of llvm to track swift module loading time.
bulbazord
force-pushed
the
swift-module-load-times
branch
from
ff68bbe
to
3bbb050
Compare
|
@swift-ci please test |
|
The first patch has been accepted and landed on llvm.org. The second patch, specific to swift, still needs review. Not sure who would be best to review it. @adrian-prantl or @kastiglione maybe? |
kastiglione
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I plan on submitting the first commit here to the llvm phabricator for review. I will link it back to this review to explain to upstream reviewers what I am doing and why.
At Meta, we make extensive use of the
statistics dumpcommand. One thing we want to track is how long each swiftmodule took to load. We've been using a version of these patches internally for a while and have found them to be useful enough to upstream.