[lldb] Limit nothreadallow to Python in SWIG bindings
#5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWIG allows you to partially disable thread support for a given function in Python with `nothreadallow`. This functionality is limited to Python, but until SWIG 4.1, it would silently ignore this for other languages, such as Lua. New versions of SWIG are more strict and therefore we need to guard this with `SWIGPYTHON`. For more details on the functionality, I recommend reading the commit message from 070a1d5. (cherry picked from commit ba35c27)
|
@swift-ci please test |
JDevlieghere
deleted the
🍒/rome/ba35c27ec9aa9807f5b4be2a0c33ca9b045accc7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIG allows you to partially disable thread support for a given function
in Python with
nothreadallow. This functionality is limited to Python,but until SWIG 4.1, it would silently ignore this for other languages,
such as Lua. New versions of SWIG are more strict and therefore we need
to guard this with
SWIGPYTHON.For more details on the functionality, I recommend reading the commit
message from 070a1d5.
(cherry picked from commit ba35c27)