[CMake] Detect properly new linker introduced in Xcode 15 #7962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This linker](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking) is functionally equivalent to the classic one (`ld64`) for build system purposes -- in particular to enable the use of order files to link `clang`. For this reason, in addition to fixing the detection rename `LLVM_LINKER_IS_LD64` to `LLVM_LINKER_IS_APPLE` to make the result of such detection more clear -- this should not cause any issue to downstream users, from a quick serch in [Sourcegraph](https://sourcegraph.com/search?q=context:global+LLVM_LINKER_IS_LD64+lang:cmake+fork:no+-file:AddLLVM.cmake+-file:clang/tools/driver/CMakeLists.txt&patternType=standard&sm=1&groupBy=repo) only Swift uses the value of this variable (which I will take care of updating in due time). rdar://120740222 (cherry picked from commit 7a7f803)
|
@swift-ci test llvm |
|
For macOS, getting almost the same failures as https://ci.swift.org/job/pr-apple-llvm-project-llvm-macos/172 (4 instead of 5), so that should confirm these are independent of this change |
|
@swift-ci test llvm |
edymtt
force-pushed
the
edymtt/detect-linker-xcode-15-apple-fork
branch
from
4140ff0
to
679f164
Compare
|
The fix worked, breaking that out in a separate PR, #7977 |
|
@swift-ci test llvm |
|
The upstream PR has been merged, so this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This linker is functionally equivalent to the classic one (
ld64) for build system purposes -- in particular to enable the use of order files to linkclang.For this reason, in addition to fixing the detection rename
LLVM_LINKER_IS_LD64toLLVM_LINKER_IS_APPLEto make the result of such detection more clear -- this should not cause any issue to downstream users, from a quick serch inSourcegraph only Swift uses the value of this variable (which I will take care of updating in due time).
rdar://120740222
(cherry picked from commit 7a7f803)