Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The covered diagnostic change hadn't landed yet in an Apple compiler release.
During qualification, we ran into the fact that the
os_log
APIs force-Wformat
to an error, and this causes a lot of churn for users dealing with this. There's some discussion upstream about what exactly the behavior of this diagnostic should be, and we're not ready to ship this.This reverts the
-Wformat
change for scoped enums for this release.For later releases, this diagnostic is moved to
-Wformat-pedantic
which shouldn't run into the same adoption issues. See: llvm#88595