fix:Update relative path in pkl-gen-go.go #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code change fixed the incorrect relative path to the GeneratorSettings.pkl file in the pkl-gen-go.go function. An additional directory level was added to effectively locate the file.
|
This PR actually fixes a breaking issue. |
The code was updated to use 'filepath.Dir' for handling file paths in the pkl-gen-go file. This change will improve the program's cross-platform compatibility by accurately dealing with different directory paths across multiple operating systems, thereby reducing potential problems with path separators and enhancing stability.
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code change fixed the incorrect relative path to the GeneratorSettings.pkl file in the pkl-gen-go.go function. An additional directory level was added to effectively locate the file.