Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: address possible nil panics #5

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix: address possible nil panics #5

merged 1 commit into from
Feb 6, 2024

Conversation

bioball
Copy link
Contributor

@bioball bioball commented Feb 6, 2024

Address possible nil panics due to url.Parse erroring.

Closes #4

@bioball
Fix: address possible nil panics
7d82a5a 
Address possible nil panics due to `url.Parse` erroring.

Closes apple#4
@bioball bioball mentioned this pull request Feb 6, 2024
Closed
stackoverflow
stackoverflow approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@stackoverflow stackoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bioball bioball merged commit 18fba06 into apple:main Feb 6, 2024
3 checks passed
@bioball bioball deleted the fix-nil-err branch February 6, 2024 15:33
@himazawa himazawa mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackoverflow stackoverflow stackoverflow approved these changes

@holzensp holzensp holzensp approved these changes

@jackkleeman jackkleeman jackkleeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible nil panic in handleReadResource
4 participants
@bioball @stackoverflow @holzensp @jackkleeman