Fix name resolution in typealias with constraint
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KushalP
force-pushed
the
fix-name-resolution-typealias-with-constraint
branch
from
ea005f8
to
46f4c0c
Compare
bioball
requested changes
Feb 15, 2024
pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAliasConstraint.pkl
Outdated
Show resolved
Hide resolved
pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAliasConstraint1.pkl
Outdated
Show resolved
Hide resolved
The body of a `typealias` gets inlined into wherever the `typealias` is used. This fixes a bug where the name resolution would resolve an additional type constraint on the next scope of `this`. Lack of a frame scope --------------------- `typealias` doesn't currently have a frame scope, which is why we have to assign the `owner` and the `receiver` here. If it did, we could read both of these at the point where we're trying to resolve the `typealias` in question.
KushalP
force-pushed
the
fix-name-resolution-typealias-with-constraint
branch
from
46f4c0c
to
bbcb5cf
Compare
|
Thanks. I have amended and pushed. |
HT154
pushed a commit
to HT154/pkl
that referenced
this pull request
Apr 2, 2024
The body of a typealias gets inlined into wherever the typealias is used. This fixes a bug where the references in the typealias body can resolve to the wrong value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The body of a
typealiasgets inlined into wherever thetypealiasis used. This fixes a bug where the name resolution would resolve an additional type constraint on the next scope ofthis.Lack of a frame scope
typealiasdoesn't currently have a frame scope, which is why we have to assign theownerand thereceiverhere. If it did, we could read both of these at the point where we're trying to resolve thetypealiasin question.