Ensure owner and receiver are reset after executing alias #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the frame's owner/receiver are not reset if a type test on a typealias fails.
bioball
commented
Mar 28, 2024
|
|
||
| res8 = new { | ||
| foo = 5 | ||
| bar = if (foo is MappingOrListing) "bar" else foo |
There was a problem hiding this comment.
This was failing in the main branch because the type check on MappingOrListing (aliasedTypeNode.execute(...) throws a (caught) type check exception. But it gets caught further up the stack, so logic for resetting the owner/receiver aren't run. Pkl then executes the else branch, and the owner/receiver are incorrectly set to the module.
holzensp
approved these changes
Mar 28, 2024
|
|
||
| res8 = new { | ||
| foo = 5 | ||
| bar = if (foo is MappingOrListing) "bar" else foo |
HT154
pushed a commit
to HT154/pkl
that referenced
this pull request
Apr 2, 2024
This fixes an issue where the frame's owner/receiver are not reset if a type test on a typealias fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the frame's owner/receiver are not reset if a type test on a typealias fails.