Turn EvalTask into a tracked Gradle task #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: "Output file names are known only after execution" isn't a legitimate reason to make this task untracked because the output directory is known in this case. This is no different from (say) the `JavaCompile` task, where only the class file output directory is known upfront. Forum discussion didn't reveal another reason why this task should be untracked.
StefMa
reviewed
Apr 4, 2024
|
A test for what exactly? |
|
Testing that if running the task twice, it will be up-to-date for the second run. |
|
I think the only potential benefit of such a test is that it fails if someone adds back |
holzensp
approved these changes
Apr 5, 2024
|
The reason this is untracked is because both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: "Output file names are known only after execution" isn't a legitimate reason to make this task untracked because the output directory is known in this case. This is no different from (say) the
JavaCompiletask, where only the class file output directory is known upfront. Forum discussion didn't reveal another reason why this task should be untracked.