Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MergeSort.java #394

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Fix MergeSort.java #394

merged 2 commits into from
Apr 5, 2024

Conversation

jw-y
Copy link
Contributor

@jw-y jw-y commented Apr 4, 2024

Fix for #393 (comment)

@bioball
Copy link
Contributor

bioball commented Apr 4, 2024

Thanks!

Let's add a test for this in

pkl/pkl-core/src/test/files/LanguageSnippetTests/input/api/list.pkl

Line 242 in 58ed824

["sortWith()"] {

Then run OVERWRITE_SNIPPETS=1 ./gradlew pkl-core:check to update the output file.

holzensp
holzensp approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@holzensp holzensp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@holzensp holzensp merged commit 0f9ef53 into apple:main Apr 5, 2024
5 checks passed
@jw-y jw-y deleted the patch-1 branch April 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holzensp holzensp holzensp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jw-y @bioball @holzensp