Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EvalTask track resolved output paths #403

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Make EvalTask track resolved output paths #403

wants to merge 10 commits into from

Commits on Jun 29, 2024

  1. Revert "Turn EvalTask into a tracked Gradle task" 

    This reverts commit 3c6df1f.

The reason that this task is untracked is because the output file
and multiple file output dir both accept placeholder values, which get
swapped out with actual values during eval.
    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    7813d43 View commit details
    Browse the repository at this point in the history

  2. Update comment with detailed explanation

    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    0630d8b View commit details
    Browse the repository at this point in the history

  3. Make EvalTask tracked again, and add derived output paths

    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    9aea25b View commit details
    Browse the repository at this point in the history

  4. Make getOutputFormat() a tracked input

    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ff5600c View commit details
    Browse the repository at this point in the history

  5. Create a provider via provider factory

    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    a1c7fd0 View commit details
    Browse the repository at this point in the history

  6. Use SetProperty to enable proper dependency tracking

    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ffefb36 View commit details
    Browse the repository at this point in the history

  7. Style fix

    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    7b77842 View commit details
    Browse the repository at this point in the history

  8. Reimplemented tracking of output files in EvalTask 

    Also added more tests for task caching behavior.
    @netvl @bioball
    netvl authored and bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    bd2a44f View commit details
    Browse the repository at this point in the history

  9. Cleanup: rename output properties

    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ca653da View commit details
    Browse the repository at this point in the history

  10. Fix merge conflict

    @bioball
    bioball committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    b897078 View commit details
    Browse the repository at this point in the history