Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NettyHttpServerConnectionAcceptorTest.testAcceptConnection[ssl=false client=CACHED server=IMMEDIATE SINGLE_ERROR] test failure #296

Closed
Scottmitch opened this issue Feb 11, 2019 · 4 comments
Closed

NettyHttpServerConnectionAcceptorTest.testAcceptConnection[ssl=false client=CACHED server=IMMEDIATE SINGLE_ERROR] test failure #296

Scottmitch opened this issue Feb 11, 2019 · 4 comments
Labels
flaky tests Unit tests are flaky

Comments

@Scottmitch
Copy link
Member

https://ci.servicetalk.io/job/servicetalk-master-prb/796/testReport/junit/io.servicetalk.http.netty/NettyHttpServerConnectionAcceptorTest/testAcceptConnection_ssl_false_client_CACHED_server_IMMEDIATE_SINGLE_ERROR_/

Error Message

java.lang.AssertionError: 
Expected: (an instance of java.io.IOException or an instance of io.servicetalk.client.api.MaxRequestLimitExceededException or an instance of io.servicetalk.client.api.NoAvailableHostException)
     but: was <io.servicetalk.client.api.ConnectionClosedException: Connection Closed: io.servicetalk.http.netty.ConcurrentRequestsHttpConnectionFilter(io.servicetalk.http.api.StreamingHttpConnectionFilter(io.servicetalk.http.netty.HostHeaderHttpRequesterFilter$2(io.servicetalk.http.netty.NonPipelinedStreamingHttpConnection([id: 0x1b613bda, L:/127.0.0.1:40554 ! R:127.0.0.1/127.0.0.1:34053]))))>
Stacktrace

java.lang.AssertionError: 
Expected: (an instance of java.io.IOException or an instance of io.servicetalk.client.api.MaxRequestLimitExceededException or an instance of io.servicetalk.client.api.NoAvailableHostException)
     but: was <io.servicetalk.client.api.ConnectionClosedException: Connection Closed: io.servicetalk.http.netty.ConcurrentRequestsHttpConnectionFilter(io.servicetalk.http.api.StreamingHttpConnectionFilter(io.servicetalk.http.netty.HostHeaderHttpRequesterFilter$2(io.servicetalk.http.netty.NonPipelinedStreamingHttpConnection([id: 0x1b613bda, L:/127.0.0.1:40554 ! R:127.0.0.1/127.0.0.1:34053]))))>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at io.servicetalk.http.netty.NettyHttpServerConnectionAcceptorTest.testAcceptConnection(NettyHttpServerConnectionAcceptorTest.java:152)
	at sun.reflect.GeneratedMethodAccessor25.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.mockito.internal.junit.JUnitRule$1.evaluateSafely(JUnitRule.java:52)
	at org.mockito.internal.junit.JUnitRule$1.evaluate(JUnitRule.java:43)
	at io.servicetalk.concurrent.internal.ServiceTalkTestTimeout$TimeoutStatement$CallableStatement.call(ServiceTalkTestTimeout.java:167)
	at io.servicetalk.concurrent.internal.ServiceTalkTestTimeout$TimeoutStatement$CallableStatement.call(ServiceTalkTestTimeout.java:159)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)
Standard Output

2019-02-10 01:05:20,486        server-io-executor-4-10 [WARN ] AbstractContextFilterChannelHandler - Exception from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@405ee891 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@44617442.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:20,611 servicetalk-global-scheduler-1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@56bed38d for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@5879272a.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:20,665        server-io-executor-4-14 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@2d4afb5f for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@29756a2e.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:21,068               client-executor1 [WARN ] AbstractContextFilterChannelHandler - Exception from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@17c49280 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@19036e08.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:21,185 servicetalk-global-scheduler-1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@5c46b8fd for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@19442d11.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:21,195               client-executor1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@53b98521 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@5d7e7126.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:21,469        server-io-executor-4-10 [WARN ] AbstractContextFilterChannelHandler - Exception from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@64a08a44 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@65020000.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:21,590 servicetalk-global-scheduler-1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@39c6a70f for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@2897976a.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:21,601        server-io-executor-4-14 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@5ff72860 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@c580e2b.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:21,892               client-executor1 [WARN ] AbstractContextFilterChannelHandler - Exception from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@619e7e37 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@6f598c74.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:22,005 servicetalk-global-scheduler-1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@41ff43d5 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@796bd25e.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:22,010               client-executor1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@54339bbd for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@5af47f4b.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:23,011        server-io-executor-4-10 [WARN ] AbstractContextFilterChannelHandler - Exception from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@121d9790 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@3b1e8543.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:23,200 servicetalk-global-scheduler-1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@7599fca3 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@612119bd.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:23,250        server-io-executor-4-14 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@81676c2 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@29dfe3fb.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:24,089               client-executor1 [WARN ] AbstractContextFilterChannelHandler - Exception from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@3bd70891 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@3510e19b.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:24,282 servicetalk-global-scheduler-1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@5afb0fa7 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@7d25cf84.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:24,397               client-executor1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@6d6c524f for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@63aba192.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:25,199        server-io-executor-4-10 [WARN ] AbstractContextFilterChannelHandler - Exception from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@789a0f36 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@64a907f0.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:25,327 servicetalk-global-scheduler-1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@47e34867 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@2ee65dd7.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:25,347        server-io-executor-4-14 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@36b2b650 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@7a1b5a85.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:25,757               client-executor1 [WARN ] AbstractContextFilterChannelHandler - Exception from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@2fb52874 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@2172c3f2.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:25,888 servicetalk-global-scheduler-1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@2c62f99b for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@7fe85a7c.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
2019-02-10 01:05:25,911               client-executor1 [WARN ] AbstractContextFilterChannelHandler - Error from context filter io.servicetalk.transport.api.ConnectionAcceptorFilter@675f5069 for context io.servicetalk.transport.netty.internal.DefaultNettyConnectionContext@6998a2f2.
io.servicetalk.concurrent.internal.DeliberateException: Deliberate Exception
@Scottmitch Scottmitch mentioned this issue Feb 11, 2019
Merged
@Scottmitch Scottmitch added the flaky tests Unit tests are flaky label Feb 11, 2019
@NiteshKant
Copy link
Collaborator

Another failure in https://ci.servicetalk.io/job/servicetalk-master-prb/803/testReport/junit/io.servicetalk.http.netty/NettyHttpServerConnectionAcceptorTest/testAcceptConnection_ssl_false_client_CACHED_server_IMMEDIATE_REJECT_ALL_/ for #271

java.lang.AssertionError: 
Expected: (an instance of java.io.IOException or an instance of io.servicetalk.client.api.MaxRequestLimitExceededException or an instance of io.servicetalk.client.api.NoAvailableHostException)
     but: was <io.servicetalk.client.api.ConnectionClosedException: Connection Closed: io.servicetalk.http.netty.ConcurrentRequestsHttpConnectionFilter(io.servicetalk.http.api.HttpConnectionFilterFactory$1(io.servicetalk.http.netty.HostHeaderHttpRequesterFilter$2(io.servicetalk.http.netty.NonPipelinedStreamingHttpConnection([id: 0xb0758783, L:/127.0.0.1:44772 ! R:127.0.0.1/127.0.0.1:40066]))))>

@NiteshKant NiteshKant mentioned this issue Feb 13, 2019
Merged
@lewisd32
Copy link
Contributor

Another failure in https://ci.servicetalk.io/job/servicetalk-master-snapshot/279/testReport/junit/io.servicetalk.http.netty/NettyHttpServerConnectionAcceptorTest/testAcceptConnection_ssl_false_client_CACHED_server_IMMEDIATE_REJECT_ALL_/

Slightly different set of parameters:

io.servicetalk.http.netty.NettyHttpServerConnectionAcceptorTest.testAcceptConnection[ssl=false client=CACHED server=IMMEDIATE REJECT_ALL]

@jayv jayv mentioned this issue Feb 13, 2019
Merged
@NiteshKant NiteshKant mentioned this issue Feb 13, 2019
Merged
@NiteshKant
Copy link
Collaborator

The test is ignored for now as it is blocking us from publishing snapshots. PR: #305

NiteshKant pushed a commit that referenced this issue Feb 13, 2019
Ignore flaky tests. (#305)
8fa5daa 
__Motivation__

Recently these tests have been flaky on CI and is blocking us from releasing a snapshot.
The issues are #296 and #295.

__Modification__

Ignore tests till we have a handle of the cause of flakiness.

__Result__

Less false negatives on CI.
@jayv
Copy link
Contributor

jayv commented Feb 15, 2019

#301 Fix merged

@jayv jayv closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky tests Unit tests are flaky
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jayv @NiteshKant @lewisd32 @Scottmitch