Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedirectingClientAndConnectionFilterTest should leverage AbstractHttpRequesterFilterTest #396

Closed
jayv opened this issue Mar 7, 2019 · 2 comments
Closed

RedirectingClientAndConnectionFilterTest should leverage AbstractHttpRequesterFilterTest #396

jayv opened this issue Mar 7, 2019 · 2 comments
Assignees
@volyx
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jayv
Copy link
Contributor

jayv commented Mar 7, 2019 •
edited

As part of #395 I noticed that RedirectingClientAndConnectionFilterTest could probably leverage the AbstractHttpRequesterFilterTest test tooling, it seems its approach is closely related to the one in RedirectingClientAndConnectionFilterTest and can reuse most of the code.
@jayv jayv added enhancement New feature or request good first issue Good for newcomers labels Mar 7, 2019
@jayv jayv mentioned this issue Mar 7, 2019
Merged
@volyx
Copy link
Contributor

volyx commented Nov 17, 2019

I will take this issue :)

@volyx volyx mentioned this issue Nov 18, 2019
Merged
NiteshKant pushed a commit that referenced this issue Nov 21, 2019
@volyx
RedirectingClientAndConnectionFilterTest should leverage AbstractHttp… (
03a7b0a 
#867)

__Motivation__

`RedirectingClientAndConnectionFilterTest` could leverage the `AbstractHttpRequesterFilterTest` test tooling. Its approach is closely related to the one in `RedirectingClientAndConnectionFilterTest` and can reuse most of the code.

__Modifications__

- `RedirectingClientAndConnectionFilterTest` extends `AbstractHttpRequesterFilterTest`
- Add `StrategyInfluencerAwareConversionsTest` for static access to package-private factory methods

__Result__

Resolves (#396): RedirectingClientAndConnectionFilterTest should leverage AbstractHttpRequesterFilterTest
@idelpivnitskiy
Copy link
Member

This issue was resolved in #867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volyx volyx

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayv @volyx @idelpivnitskiy