Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spotbugs 4.2.2 -> 4.2.3, spotbugs-plugin 4.7.0 -> 4.7.1 #1543

Merged
merged 3 commits into from Jun 18, 2021
Merged

Update spotbugs 4.2.2 -> 4.2.3, spotbugs-plugin 4.7.0 -> 4.7.1 #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
100cc72
Update spotbugs 4.2.2 -> 4.2.3, spotbugs-plugin 4.7.0 -> 4.7.1
idelpivnitskiy May 11, 2021
246e00d
Suppress all false positive `DMI_RANDOM_USED_ONLY_ONCE` warnings
idelpivnitskiy Jun 18, 2021
85a31b4
Merge remote-tracking branch 'upstream/main' into spotbugs
idelpivnitskiy Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@ junit5Version=5.7.1
testngVersion=6.14.3
hamcrestVersion=1.3
mockitoCoreVersion=2.28.2
spotbugsPluginVersion=4.7.0
spotbugsPluginVersion=4.7.1

apacheDirectoryServerVersion=1.5.7
commonsLangVersion=2.6
Expand Down
5 changes: 5 additions & 0 deletions servicetalk-benchmarks/gradle/spotbugs/jmh-exclusions.xml
View file
Open in desktop
Expand Up @@ -20,6 +20,11 @@
<Source name="~.*Benchmark\.java"/>
<Bug pattern="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
</Match>
<!-- SpotBugs does not understand that method is invoked multiple times -->
<Match>
<Source name="~.*Benchmark\.java"/>
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
</Match>
<!-- SpotBugs does not understand that subscription field will be initialized -->
<Match>
<Class name="io.servicetalk.benchmark.concurrent.ConnectableBufferOutputStreamBenchmark"/>
Expand Down
5 changes: 5 additions & 0 deletions servicetalk-concurrent-api-internal/gradle/spotbugs/test-exclusions.xml
View file
Open in desktop
Expand Up @@ -20,4 +20,9 @@
<Source name="~.*Test\.java"/>
<Bug pattern="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
</Match>
<!-- SpotBugs incorrectly detects number of usages in a loop -->
<Match>
<Source name="~.*Test\.java"/>
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
</Match>
</FindBugsFilter>
5 changes: 5 additions & 0 deletions servicetalk-concurrent-internal/gradle/spotbugs/test-exclusions.xml
View file
Open in desktop
Expand Up @@ -20,4 +20,9 @@
<Source name="~.*Test\.java"/>
<Bug pattern="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
</Match>
<!-- SpotBugs incorrectly detects number of usages in a loop -->
<Match>
<Source name="~.*Test\.java"/>
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
</Match>
</FindBugsFilter>
6 changes: 6 additions & 0 deletions servicetalk-dns-discovery-netty/gradle/spotbugs/test-exclusions.xml
View file
Open in desktop
Expand Up @@ -25,4 +25,10 @@
<Source name="~.*Test\.java"/>
<Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>
</Match>
<!-- SpotBugs incorrectly detects number of usages -->
<Match>
<Class name="io.servicetalk.dns.discovery.netty.DnsTestUtils"/>
<Method name="index"/>
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
</Match>
</FindBugsFilter>
2 changes: 1 addition & 1 deletion ...dle-plugin-internal/src/main/groovy/io/servicetalk/gradle/plugin/internal/Versions.groovy
View file
Open in desktop
Expand Up @@ -22,6 +22,6 @@ import static org.gradle.api.JavaVersion.VERSION_1_8
final class Versions {
static final String CHECKSTYLE_VERSION = "8.43"
static final String PMD_VERSION = "6.35.0"
static final String SPOTBUGS_VERSION = "4.2.2"
static final String SPOTBUGS_VERSION = "4.2.3"
static final JavaVersion TARGET_VERSION = VERSION_1_8
}
6 changes: 6 additions & 0 deletions servicetalk-http-router-jersey/gradle/spotbugs/testFixtures-exclusions.xml
View file
Open in desktop
Expand Up @@ -20,4 +20,10 @@
<Source name="~.*Test\.java"/>
<Bug pattern="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
</Match>
<!-- SpotBugs incorrectly detects number of usages -->
<Match>
<Class name="io.servicetalk.http.router.jersey.TestUtils"/>
<Method name="newLargePayload"/>
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
</Match>
</FindBugsFilter>