Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collect() for Single and Completable #186

Merged
merged 3 commits into from
Dec 2, 2018
Merged

Add collect() for Single and Completable #186

merged 3 commits into from
Dec 2, 2018

Commits on Dec 1, 2018

  1. Add collect() for Single and Completable 

    __Motivation__

Today, in order to asynchronously collect a known set of `Single`/`Completable`, one has to use `Publisher`.
This creates friction as many users are not comfortable dealing with streaming APIs. We can add a shorthand for `collect()` to help such users.

__Modification__

Added static `collect()` variants for `Single` and `Completable`
Also added `Publisher#flatMapCompletable()` as that is required for `Completable#collect()`

__Result__

Less friction for scalar API users.
    Nitesh Kant committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    7632bd9 View commit details
    Browse the repository at this point in the history

  2. Review comments

    Nitesh Kant committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    5efef24 View commit details
    Browse the repository at this point in the history

  3. Review comments

    Nitesh Kant committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    b45240e View commit details
    Browse the repository at this point in the history