Deprecate unused exception types #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: There are a few custom exception types that were used in the past, but became unusable after some refactoring. It's safe to deprecate them and remove in future releases. Modifications: - Deprecate `ConnectionClosedException`, `InvalidRedirectException` `MaxRequestLimitExceededException`, `MaxRequestLimitExceededRejectedSubscribeException`; Result: All unused exception types are deprecated now.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Oct 29, 2021
Motivation: There are a few custom exception types that are unused and were deprecated in apple#1920. We can remove them now. Modifications: - Remove `ConnectionClosedException`, `InvalidRedirectException` `MaxRequestLimitExceededException`, `MaxRequestLimitExceededRejectedSubscribeException`; Result: No unused exception types.
chemicL
approved these changes
Nov 2, 2021
idelpivnitskiy
added a commit
that referenced
this pull request
Nov 2, 2021
Motivation: There are a few custom exception types that were used in the past but became unusable after some refactoring. It's safe to deprecate them and remove in future releases. Modifications: - Deprecate `ConnectionClosedException`, `InvalidRedirectException` `MaxRequestLimitExceededException`, `MaxRequestLimitExceededRejectedSubscribeException`; - Avoid using deprecated exceptions in tests; Result: All unused exception types are deprecated now.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Nov 2, 2021
Motivation: There are a few custom exception types that are unused and were deprecated in apple#1920. We can remove them now. Modifications: - Remove `ConnectionClosedException`, `InvalidRedirectException` `MaxRequestLimitExceededException`, `MaxRequestLimitExceededRejectedSubscribeException`; Result: No unused exception types.
idelpivnitskiy
added a commit
that referenced
this pull request
Nov 2, 2021
Motivation: There are a few custom exception types that are unused and were deprecated in #1920. We can remove them now. Modifications: - Remove `ConnectionClosedException`, `InvalidRedirectException` `MaxRequestLimitExceededException`, `MaxRequestLimitExceededRejectedSubscribeException`; Result: No unused exception types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There are a few custom exception types that were used in the past, but
became unusable after some refactoring. It's safe to deprecate them and
remove in future releases.
Modifications:
ConnectionClosedException,InvalidRedirectExceptionMaxRequestLimitExceededException,MaxRequestLimitExceededRejectedSubscribeException;Result:
All unused exception types are deprecated now.