Add the SkipWhile operator to Publisher #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's useful to be able to skip elements of a stream until a predicate fails but that isn't yet supported in Servicetalk. Modifications: Add the SkipWhile operator to the Servicetalk Publisher class. Result: SkipWhile is now supported.
bryce-anderson
commented
Mar 22, 2023
| @@ -297,7 +297,7 @@ If HTTP/1.x protocol is configured ServiceTalk always fallbacks to it if the pee | |||
| IMPORTANT: Your runtime must support ALPN extension for TLS. The recommended way is to use OpenSSL provider and add | |||
| link:https://netty.io/wiki/forked-tomcat-native.html#artifacts[netty-tcnative] artifact to the classpath. If OpenSSL is | |||
| not available, make sure your JVM version supports ALPN or use | |||
| link:https://www.eclipse.org/jetty/documentation/current/alpn-chapter.html[another provider] that supports it. | |||
There was a problem hiding this comment.
The current link results in a 404.
Scottmitch
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
suggestion on test but lgtm!
fyi when adding new operators we usually add a ReactiveStreams TCK test (see PublisherFilterTckTest). Looks like I didn't do this for Publisher.distinct() which is similar but not sure if it was an omission or bcz TCK wouldn't fail if duplicates aren't emitted.
...talk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/SkipWhileTest.java
Outdated
Show resolved
Hide resolved
...talk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/SkipWhileTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's useful to be able to skip elements of a stream until a predicate fails but that isn't yet supported in Servicetalk.
Modifications:
Add the SkipWhile operator to the Servicetalk Publisher class.
Result:
SkipWhile is now supported.