Add SslConfig#maxCertificateListBytes() #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR build expected to fail currently. lower limit isn't failing handshake as expected, more investigation required. |
Scottmitch
force-pushed
the
max_cert_size
branch
2 times, most recently
from
50da265
to
3f93316
Compare
Scottmitch
force-pushed
the
max_cert_size
branch
2 times, most recently
from
5b12c38
to
172f967
Compare
Scottmitch
force-pushed
the
max_cert_size
branch
from
172f967
to
a1dc565
Compare
Motivation: Some use cases have certificate chains larger than the BoringSSL default limit. This may result in handshake failures and there is no way to configure the maximum value. Modifications: - Add SslConfig#maxCertificateListBytes() and corresponding builder methods to allow configuring the limit (if supported by SSLEngine).
Scottmitch
force-pushed
the
max_cert_size
branch
from
a1dc565
to
3ca0c54
Compare
bryce-anderson
approved these changes
Jun 30, 2023
...etalk-transport-api/src/main/java/io/servicetalk/transport/api/AbstractSslConfigBuilder.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private static SslContext configureBuilder(SslConfig config, SslContextBuilder builder, boolean forServer) { |
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/SslCertificateMaxSizeTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some use cases have certificate chains larger than the BoringSSL default limit. This may result in handshake failures and there is no way to configure the maximum value.
Modifications: